From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: [PATCH v2 3/6] ARM: AM43xx: Introduce a separate soc_is function for am438x series of SoCs Date: Thu, 13 Aug 2015 02:59:15 -0700 Message-ID: <20150813095915.GD4215@atomide.com> References: <1439198906-31189-1-git-send-email-j-keerthy@ti.com> <1439198906-31189-4-git-send-email-j-keerthy@ti.com> <20150811125515.GN4215@atomide.com> <55CA36D2.3080509@ti.com> <20150812083718.GS4215@atomide.com> <55CC5DB4.7040704@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <55CC5DB4.7040704-l0cyMroinI0@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Keerthy Cc: Keerthy , linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, pawel.moll-5wv7dgnIgG8@public.gmane.org, galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org, paul-DWxLp4Yu+b8AvxtiuMwx3w@public.gmane.org, alexandre.belloni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org, akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org, johan-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, grygorii.strashko-l0cyMroinI0@public.gmane.org, rtc-linux-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org, bcousson-rdvid1DuHRBWk0Htik3J/w@public.gmane.org, nm-l0cyMroinI0@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, t-kristo-l0cyMroinI0@public.gmane.org List-Id: linux-omap@vger.kernel.org * Keerthy [150813 02:08]: > > > On Wednesday 12 August 2015 02:07 PM, Tony Lindgren wrote: > >* Keerthy [150811 10:57]: > >> > >> > >>On Tuesday 11 August 2015 06:25 PM, Tony Lindgren wrote: > >>>* Keerthy [150810 02:31]: > >>>>@@ -371,8 +372,10 @@ IS_OMAP_TYPE(3430, 0x3430) > >>>> #ifdef CONFIG_SOC_AM43XX > >>>> # undef soc_is_am43xx > >>>> # undef soc_is_am437x > >>>>-# define soc_is_am43xx() is_am43xx() > >>>>-# define soc_is_am437x() is_am437x() > >>>>+# undef soc_is_am438x > >>>>+# define soc_is_am43xx() of_machine_is_compatible("ti,am43") > >>>>+# define soc_is_am437x() of_machine_is_compatible("ti,am4372") > >>>>+# define soc_is_am438x() of_machine_is_compatible("ti,am438x") > >>>> #endif > >>> > >>>Hmm didn't I already comment on this change? I don't want to do it > >>>for one SoC. Please add the SoC detection the old way for am43xx, > >>>then do another series that changes all the DT only SoCs to use > >>>of_machine_is_compatible() after it's been properly tested so now > >>>regressions are caused for the early init code. > >> > >>Okay. I misinterpreted your earlier comment. Thanks for clarifying. > >>I will re-do. > > > >Actually, can you please do the following patches first while at it: > > > >1. Change dra7 SoC detection to intialize soc_name and soc_rev > > registers based on the of_machine_is_compatible so we don't > > do pointless string comparisons with the current code > > just another confirmation. So the intent here is to directly do > of_machine_is_compatible checks instead if soc_is_dra* and try to remove > soc_is calls from mach-omap2 code right? Only do of_machine_is_compatible check once to initialize the necessary variables for soc_is_* to use. Rgarads, Tony -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from muru.com (muru.com. [72.249.23.125]) by gmr-mx.google.com with ESMTP id 4si163402igl.1.2015.08.13.02.59.22 for ; Thu, 13 Aug 2015 02:59:22 -0700 (PDT) Date: Thu, 13 Aug 2015 02:59:15 -0700 From: Tony Lindgren To: Keerthy Cc: Keerthy , linux-omap@vger.kernel.org, pawel.moll@arm.com, galak@codeaurora.org, paul@pwsan.com, alexandre.belloni@free-electrons.com, akpm@linux-foundation.org, johan@kernel.org, grygorii.strashko@ti.com, rtc-linux@googlegroups.com, bcousson@baylibre.com, nm@ti.com, devicetree@vger.kernel.org, t-kristo@ti.com Subject: [rtc-linux] Re: [PATCH v2 3/6] ARM: AM43xx: Introduce a separate soc_is function for am438x series of SoCs Message-ID: <20150813095915.GD4215@atomide.com> References: <1439198906-31189-1-git-send-email-j-keerthy@ti.com> <1439198906-31189-4-git-send-email-j-keerthy@ti.com> <20150811125515.GN4215@atomide.com> <55CA36D2.3080509@ti.com> <20150812083718.GS4215@atomide.com> <55CC5DB4.7040704@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 In-Reply-To: <55CC5DB4.7040704@ti.com> Reply-To: rtc-linux@googlegroups.com List-ID: List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , * Keerthy [150813 02:08]: > > > On Wednesday 12 August 2015 02:07 PM, Tony Lindgren wrote: > >* Keerthy [150811 10:57]: > >> > >> > >>On Tuesday 11 August 2015 06:25 PM, Tony Lindgren wrote: > >>>* Keerthy [150810 02:31]: > >>>>@@ -371,8 +372,10 @@ IS_OMAP_TYPE(3430, 0x3430) > >>>> #ifdef CONFIG_SOC_AM43XX > >>>> # undef soc_is_am43xx > >>>> # undef soc_is_am437x > >>>>-# define soc_is_am43xx() is_am43xx() > >>>>-# define soc_is_am437x() is_am437x() > >>>>+# undef soc_is_am438x > >>>>+# define soc_is_am43xx() of_machine_is_compatible("ti,am43") > >>>>+# define soc_is_am437x() of_machine_is_compatible("ti,am4372") > >>>>+# define soc_is_am438x() of_machine_is_compatible("ti,am438x") > >>>> #endif > >>> > >>>Hmm didn't I already comment on this change? I don't want to do it > >>>for one SoC. Please add the SoC detection the old way for am43xx, > >>>then do another series that changes all the DT only SoCs to use > >>>of_machine_is_compatible() after it's been properly tested so now > >>>regressions are caused for the early init code. > >> > >>Okay. I misinterpreted your earlier comment. Thanks for clarifying. > >>I will re-do. > > > >Actually, can you please do the following patches first while at it: > > > >1. Change dra7 SoC detection to intialize soc_name and soc_rev > > registers based on the of_machine_is_compatible so we don't > > do pointless string comparisons with the current code > > just another confirmation. So the intent here is to directly do > of_machine_is_compatible checks instead if soc_is_dra* and try to remove > soc_is calls from mach-omap2 code right? Only do of_machine_is_compatible check once to initialize the necessary variables for soc_is_* to use. Rgarads, Tony -- -- You received this message because you are subscribed to "rtc-linux". Membership options at http://groups.google.com/group/rtc-linux . Please read http://groups.google.com/group/rtc-linux/web/checklist before submitting a driver. --- You received this message because you are subscribed to the Google Groups "rtc-linux" group. To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com. For more options, visit https://groups.google.com/d/optout.