From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kalle Valo Date: Thu, 13 Aug 2015 12:26:54 +0000 (UTC) Subject: [ath9k-devel] ath9k_htc: wmi: match wait_for_completion_timeout return type In-Reply-To: <1431621821-8173-1-git-send-email-hofrat@osadl.org> Message-ID: <20150813122654.733DA14037D@smtp.codeaurora.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: ath9k-devel@lists.ath9k.org > Return type of wait_for_completion_timeout is unsigned long not int. > As time_left is exclusively used for wait_for_completion_timeout here its > type is simply changed to unsigned long. > > API conformance testing for completions with coccinelle spatches are being > used to locate API usage inconsistencies: > ./drivers/net/wireless/ath/ath9k/wmi.c:331 > int return assigned to unsigned long > > Patch was compile tested with x86_64_defconfig + CONFIG_ATH_CARDS=m, > CONFIG_ATH9K_HTC=m > > Patch is against 4.1-rc3 (localversion-next is -next-20150514) > > Signed-off-by: Nicholas Mc Guire Thanks, applied to wireless-drivers-next.git. Kalle Valo From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from smtp.codeaurora.org ([198.145.29.96]:54615 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752004AbbHMM0z (ORCPT ); Thu, 13 Aug 2015 08:26:55 -0400 Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Subject: Re: ath9k_htc: wmi: match wait_for_completion_timeout return type From: Kalle Valo In-Reply-To: <1431621821-8173-1-git-send-email-hofrat@osadl.org> To: Nicholas Mc Guire Cc: QCA ath9k Development , linux-wireless@vger.kernel.org, ath9k-devel@venema.h4ckr.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Nicholas Mc Guire Message-Id: <20150813122654.733DA14037D@smtp.codeaurora.org> (sfid-20150813_142721_301404_B3BF8FD0) Date: Thu, 13 Aug 2015 12:26:54 +0000 (UTC) Sender: linux-wireless-owner@vger.kernel.org List-ID: > Return type of wait_for_completion_timeout is unsigned long not int. > As time_left is exclusively used for wait_for_completion_timeout here its > type is simply changed to unsigned long. > > API conformance testing for completions with coccinelle spatches are being > used to locate API usage inconsistencies: > ./drivers/net/wireless/ath/ath9k/wmi.c:331 > int return assigned to unsigned long > > Patch was compile tested with x86_64_defconfig + CONFIG_ATH_CARDS=m, > CONFIG_ATH9K_HTC=m > > Patch is against 4.1-rc3 (localversion-next is -next-20150514) > > Signed-off-by: Nicholas Mc Guire Thanks, applied to wireless-drivers-next.git. Kalle Valo From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kalle Valo Subject: Re: ath9k_htc: wmi: match wait_for_completion_timeout return type Date: Thu, 13 Aug 2015 12:26:54 +0000 (UTC) Message-ID: <20150813122654.733DA14037D@smtp.codeaurora.org> References: <1431621821-8173-1-git-send-email-hofrat@osadl.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: ath9k-devel@venema.h4ckr.net, netdev@vger.kernel.org, linux-wireless@vger.kernel.org, QCA ath9k Development , linux-kernel@vger.kernel.org, Nicholas Mc Guire To: Nicholas Mc Guire Return-path: In-Reply-To: <1431621821-8173-1-git-send-email-hofrat@osadl.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: ath9k-devel-bounces@lists.ath9k.org Errors-To: ath9k-devel-bounces@lists.ath9k.org List-Id: netdev.vger.kernel.org > Return type of wait_for_completion_timeout is unsigned long not int. > As time_left is exclusively used for wait_for_completion_timeout here its > type is simply changed to unsigned long. > > API conformance testing for completions with coccinelle spatches are being > used to locate API usage inconsistencies: > ./drivers/net/wireless/ath/ath9k/wmi.c:331 > int return assigned to unsigned long > > Patch was compile tested with x86_64_defconfig + CONFIG_ATH_CARDS=m, > CONFIG_ATH9K_HTC=m > > Patch is against 4.1-rc3 (localversion-next is -next-20150514) > > Signed-off-by: Nicholas Mc Guire Thanks, applied to wireless-drivers-next.git. Kalle Valo