All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kalle Valo <kvalo@codeaurora.org>
To: Larry Finger <Larry.Finger@lwfinger.net>
Cc: linux-wireless@vger.kernel.org,
	Larry Finger <Larry.Finger@lwfinger.net>,
	David Binderman <dcb314@hotmail.com>
Subject: Re: [NEXT] rtlwifi: rtl8192c-common: Fix two typos
Date: Thu, 13 Aug 2015 12:33:14 +0000 (UTC)	[thread overview]
Message-ID: <20150813123314.3695D140630@smtp.codeaurora.org> (raw)
In-Reply-To: <1438636553-28465-1-git-send-email-Larry.Finger@lwfinger.net>


> In this driver, two variables are masked by one quantity, and then tested
> against a second number with more bits that the mask. Accordingly, the
> test always fails. To minimize the possibility of such typos, a symbolic
> definition of the mask is created and used.
> 
> The separate load and mask operations are also combined into a single
> statement.
> 
> Reported-by: David Binderman <dcb314@hotmail.com>
> Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
> Cc: David Binderman <dcb314@hotmail.com>

Thanks, applied to wireless-drivers-next.git.

Kalle Valo

      reply	other threads:[~2015-08-13 12:33 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-03 21:15 [PATCH NEXT] rtlwifi: rtl8192c-common: Fix two typos Larry Finger
2015-08-13 12:33 ` Kalle Valo [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150813123314.3695D140630@smtp.codeaurora.org \
    --to=kvalo@codeaurora.org \
    --cc=Larry.Finger@lwfinger.net \
    --cc=dcb314@hotmail.com \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.