From: Christoph Hellwig <hch-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
To: Jason Gunthorpe
<jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
Cc: Christoph Hellwig <hch-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>,
Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
Chuck Lever <chuck.lever-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>,
Steve Wise
<swise-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org>,
"linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Sagi Grimberg <sagig-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
Subject: Re: [RFC] split struct ib_send_wr
Date: Thu, 13 Aug 2015 10:53:54 -0700 [thread overview]
Message-ID: <20150813175354.GA4566@infradead.org> (raw)
In-Reply-To: <20150813172234.GB13535-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
On Thu, Aug 13, 2015 at 11:22:34AM -0600, Jason Gunthorpe wrote:
> The uverbs change needs to drop/move the original kmalloc:
>
> next = kmalloc(ALIGN(sizeof *next, sizeof (struct ib_sge)) +
> user_wr->num_sge * sizeof (struct ib_sge),
> GFP_KERNEL);
>
> It looks like it is leaking that allocation right now. Every path
> replaces next with the result of alloc_mr..
Thanks. It should be come and indeed was in my first version. Not
sure how it sneaked in during a rebase.
> Noticed a couple of trailing whitespaces too..
checkpatch found two of them, which I've fixed now.
New version at:
http://git.infradead.org/users/hch/rdma.git/commitdiff/5d7e6fa563dae32d4b6f63e29e3795717a545f11
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2015-08-13 17:53 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-04 14:34 [RFC] split struct ib_send_wr Christoph Hellwig
[not found] ` <20150804143447.GA22172-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
2015-08-04 16:07 ` Hefty, Sean
[not found] ` <1828884A29C6694DAF28B7E6B8A82373A902272C-P5GAC/sN6hkd3b2yrw5b5LfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2015-08-04 16:29 ` Christoph Hellwig
[not found] ` <20150804162924.GA4867-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
2015-08-04 16:36 ` Bart Van Assche
[not found] ` <55C0EA21.2070609-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
2015-08-04 16:41 ` Christoph Hellwig
2015-08-06 4:40 ` Jason Gunthorpe
[not found] ` <20150806044008.GB14153-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2015-08-06 9:47 ` Christoph Hellwig
2015-08-06 16:24 ` Christoph Hellwig
[not found] ` <20150806162438.GA27608-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
2015-08-06 16:46 ` Sagi Grimberg
[not found] ` <55C38F74.7070200-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
2015-08-07 7:05 ` Christoph Hellwig
2015-08-06 17:04 ` Steve Wise
[not found] ` <55C393A0.6000002-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org>
2015-08-06 17:31 ` Christoph Hellwig
[not found] ` <20150806173143.GA25497-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
2015-08-06 17:44 ` Steve Wise
2015-08-06 17:58 ` Chuck Lever
[not found] ` <0B199DE1-B76A-44BD-91BC-E4285E439C70-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
2015-08-07 6:36 ` Christoph Hellwig
[not found] ` <20150807063637.GE31458-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
2015-08-07 14:17 ` Chuck Lever
[not found] ` <72E34077-7332-4F7D-8498-E67E7192CD2A-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
2015-08-07 14:19 ` Christoph Hellwig
[not found] ` <20150807141929.GA12442-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
2015-08-13 1:45 ` Doug Ledford
[not found] ` <55CBF6C1.8010803-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-08-13 2:24 ` Chuck Lever
[not found] ` <79BCB01F-AD69-4BEB-8F03-F5A52701211E-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
2015-08-13 5:54 ` Christoph Hellwig
[not found] ` <20150813055450.GA19344-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
2015-08-13 13:07 ` Doug Ledford
[not found] ` <55CC9682.1020203-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-08-13 16:04 ` Christoph Hellwig
[not found] ` <20150813160439.GA32690-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
2015-08-13 16:46 ` Chuck Lever
2015-08-13 17:22 ` Jason Gunthorpe
[not found] ` <20150813172234.GB13535-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2015-08-13 17:53 ` Christoph Hellwig [this message]
[not found] ` <20150813175354.GA4566-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
2015-08-13 18:01 ` Jason Gunthorpe
2015-08-17 7:20 ` Christoph Hellwig
2015-08-07 6:36 ` 'Christoph Hellwig'
2015-08-06 17:38 ` Parav Pandit
[not found] ` <CAG53R5VWR99OUmVTYWjvQiPKDuZ=ogbsEyfTJMcURjeohYyLmQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-08-07 6:35 ` Christoph Hellwig
2015-08-07 18:56 ` Steve Wise
2015-08-10 23:44 ` Bart Van Assche
2015-08-12 17:24 ` Sagi Grimberg
[not found] ` <55CB8161.8040702-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
2015-08-13 15:38 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150813175354.GA4566@infradead.org \
--to=hch-wegcikhe2lqwvfeawa7xhq@public.gmane.org \
--cc=chuck.lever-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org \
--cc=dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=sagig-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
--cc=swise-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.