From: Calvin Owens <calvinowens@fb.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: Sorin Dumitru <sorin@returnze.ro>,
Sorin Dumitru <sdumitru@ixiacom.com>,
David Miller <davem@davemloft.net>, <kuznet@ms2.inr.ac.ru>,
<jmorris@namei.org>, <yoshfuji@linux-ipv6.org>, <kaber@trash.net>,
netdev <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<kernel-team@fb.com>
Subject: Re: [PATCH] net: Use SK_MEM_QUANTUM as minimum for tcp/udp rmem/wmem
Date: Thu, 13 Aug 2015 14:07:04 -0700 [thread overview]
Message-ID: <20150813210704.GA3055575@mail.thefacebook.com> (raw)
In-Reply-To: <1439401585.29802.15.camel@edumazet-glaptop2.roam.corp.google.com>
On Wednesday 08/12 at 10:46 -0700, Eric Dumazet wrote:
> On Wed, 2015-08-12 at 20:00 +0300, Sorin Dumitru wrote:
>
> > Would clamping the values to a min value, like setsockopt(SO_SNDBUF)
> > does, be an option?
> > I still find it odd that SO_SNDBUF limits you, while the /proc
> > interface doesn't. If you think it's
> > too much, I'm ok with reverting it since it affects scripts.
> >
> > On those arches where PAGE_SIZE == 64K(or > 16K) it looks like we have
> > tcp_wmem[1]
> > smaller than tcp_wmem[0]. Shouldn't we do something about this?
>
> As long as we do not crash if/when root user changes /proc/sys/net
> settings, we are good.
Using "1 1 1" for tcp_{r,w}mem seems not to explode, so this sounds good
to me. I'll send a new patch reverting the original.
Thanks,
Calvin
> I would not care if performance is bad if root does something really
> stupid. root user is supposed to not mess things just for fun.
next prev parent reply other threads:[~2015-08-13 21:07 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-05 20:26 [PATCH] net: Unbreak resetting default values for tcp_wmem/udp_wmem_min Calvin Owens
2015-08-10 5:41 ` David Miller
2015-08-11 3:34 ` Calvin Owens
2015-08-11 3:46 ` David Miller
2015-08-12 4:54 ` [PATCH] net: Use SK_MEM_QUANTUM as minimum for tcp/udp rmem/wmem Calvin Owens
2015-08-12 14:21 ` Eric Dumazet
2015-08-12 17:00 ` Sorin Dumitru
2015-08-12 17:46 ` Eric Dumazet
2015-08-13 21:07 ` Calvin Owens [this message]
2015-08-13 21:21 ` [PATCH] Revert "net: limit tcp/udp rmem/wmem to SOCK_{RCV,SND}BUF_MIN" Calvin Owens
2015-08-13 22:56 ` Eric Dumazet
2015-08-17 19:11 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150813210704.GA3055575@mail.thefacebook.com \
--to=calvinowens@fb.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=jmorris@namei.org \
--cc=kaber@trash.net \
--cc=kernel-team@fb.com \
--cc=kuznet@ms2.inr.ac.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sdumitru@ixiacom.com \
--cc=sorin@returnze.ro \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.