All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] usb_storage: USB storage transfer size increase for xHCI
Date: Thu, 13 Aug 2015 21:09:02 +0200	[thread overview]
Message-ID: <201508132109.02973.marex@denx.de> (raw)
In-Reply-To: <1439492404-1606-1-git-send-email-s.temerkhanov@gmail.com>

On Thursday, August 13, 2015 at 09:00:04 PM, Sergey Temerkhanov wrote:
> Increase xHCI transfer size for USB storage devices. This helps to
> achieve 10-20x speedup for large transfers
> 
> Signed-off-by: Sergey Temerkhanov <s.temerkhanov@gmail.com>
> Signed-off-by: Radha Mohan Chintakuntla <rchintakuntla@cavium.com>

Hi!

> ---
> 
>  common/usb_storage.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/common/usb_storage.c b/common/usb_storage.c
> index b978430..ee5acca 100644
> --- a/common/usb_storage.c
> +++ b/common/usb_storage.c
> @@ -97,13 +97,15 @@ struct us_data {
>  	trans_cmnd	transport;		/* transport routine */
>  };
> 
> -#ifdef CONFIG_USB_EHCI
> +#if defined(CONFIG_USB_EHCI)
>  /*
>   * The U-Boot EHCI driver can handle any transfer length as long as there
> is * enough free heap space left, but the SCSI READ(10) and WRITE(10)
> commands are * limited to 65535 blocks.
>   */
>  #define USB_MAX_XFER_BLK	65535
> +#elif defined(CONFIG_USB_XHCI)

Why don't you keep the XHCI consistent with EHCI, ie 64k transfers as well ?

> +#define USB_MAX_XFER_BLK	4096
>  #else
>  #define USB_MAX_XFER_BLK	20
>  #endif

Best regards,
Marek Vasut

  reply	other threads:[~2015-08-13 19:09 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-13 19:00 [U-Boot] [PATCH] usb_storage: USB storage transfer size increase for xHCI Sergey Temerkhanov
2015-08-13 19:09 ` Marek Vasut [this message]
2015-08-13 19:13   ` Sergei Temerkhanov
2015-08-13 19:34     ` Marek Vasut
     [not found]       ` <CAPEA6dY71DZhHb61c_+RfdvsM0PvzXRxY1nSw9zFPaqvTYzUgQ@mail.gmail.com>
2015-08-13 22:42         ` Marek Vasut
2015-08-14 12:09           ` Sergei Temerkhanov
2015-08-14 12:15             ` Marek Vasut
2015-08-13 22:48       ` Sergei Temerkhanov
2015-08-13 23:12         ` Marek Vasut

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201508132109.02973.marex@denx.de \
    --to=marex@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.