From: Dan Carpenter <dan.carpenter@oracle.com>
To: michal.kazior@tieto.com
Cc: ath10k@lists.infradead.org
Subject: re: ath10k: remove DMA mapping wrappers
Date: Fri, 14 Aug 2015 00:21:30 +0300 [thread overview]
Message-ID: <20150813212130.GA15856@mwanda> (raw)
Hello Michal Kazior,
The patch 767d34fc67af: "ath10k: remove DMA mapping wrappers" from
Feb 27, 2014, leads to the following static checker warning:
drivers/net/wireless/ath/ath10k/htt_tx.c:445 ath10k_htt_mgmt_tx()
warn: dma_mapping_error() doesn't return an error code
drivers/net/wireless/ath/ath10k/htt_tx.c
443 skb_cb->paddr = dma_map_single(dev, msdu->data, msdu->len,
444 DMA_TO_DEVICE);
445 res = dma_mapping_error(dev, skb_cb->paddr);
446 if (res)
447 goto err_free_txdesc;
448
We should be returning an error code here instead of 1. There are
several of these bugs.
drivers/net/wireless/ath/ath10k/htt_tx.c:530 ath10k_htt_tx() warn: dma_mapping_error() doesn't return an error code
drivers/net/wireless/ath/ath10k/pci.c:1667 ath10k_pci_hif_exchange_bmi_msg() warn: dma_mapping_error() doesn't return an error code
drivers/net/wireless/ath/ath10k/htc.c:147 ath10k_htc_send() warn: dma_mapping_error() doesn't return an error code
regards,
dan carpenter
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
reply other threads:[~2015-08-13 21:21 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150813212130.GA15856@mwanda \
--to=dan.carpenter@oracle.com \
--cc=ath10k@lists.infradead.org \
--cc=michal.kazior@tieto.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.