From: Greg-KH <gregkh@linuxfoundation.org>
To: "Nicholas A. Bellinger" <nab@linux-iscsi.org>
Cc: target-devel <target-devel@vger.kernel.org>,
stable <stable@vger.kernel.org>,
Sagi Grimberg <sagig@mellanox.com>
Subject: Re: [PATCH-v3.10.y] iscsi-target: Fix iscsit_start_kthreads failure OOPs
Date: Thu, 13 Aug 2015 17:45:43 -0700 [thread overview]
Message-ID: <20150814004543.GA23652@kroah.com> (raw)
In-Reply-To: <1439496730-18376-2-git-send-email-nab@linux-iscsi.org>
On Thu, Aug 13, 2015 at 08:12:10PM +0000, Nicholas A. Bellinger wrote:
> From: Nicholas Bellinger <nab@linux-iscsi.org>
>
> This patch fixes a regression introduced with the following commit
> in v4.0-rc1 code, where a iscsit_start_kthreads() failure triggers
> a NULL pointer dereference OOPs:
>
> commit 88dcd2dab5c23b1c9cfc396246d8f476c872f0ca
> Author: Nicholas Bellinger <nab@linux-iscsi.org>
> Date: Thu Feb 26 22:19:15 2015 -0800
>
> iscsi-target: Convert iscsi_thread_set usage to kthread.h
>
> To address this bug, move iscsit_start_kthreads() immediately
> preceeding the transmit of last login response, before signaling
> a successful transition into full-feature-phase within existing
> iscsi_target_do_tx_login_io() logic.
>
> This ensures that no target-side resource allocation failures can
> occur after the final login response has been successfully sent.
>
> Also, it adds a iscsi_conn->rx_login_comp to allow the RX thread
> to sleep to prevent other socket related failures until the final
> iscsi_post_login_handler() call is able to complete.
>
> Issue DAT-3610
>
> Change-Id: Ie41cd45dba698d4984ca711a56e4ffd3bb32ca6d
What is that here for?
I need to know the git commit id in Linus's tree, I guess I have to go
dig it out now...
next prev parent reply other threads:[~2015-08-14 0:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-13 20:12 [PATCH-v3.10.y] iscsi-target: Stable backports Nicholas A. Bellinger
2015-08-13 20:12 ` [PATCH-v3.10.y] iscsi-target: Fix iscsit_start_kthreads failure OOPs Nicholas A. Bellinger
2015-08-14 0:45 ` Greg-KH [this message]
2015-08-14 0:48 ` Nicholas A. Bellinger
2015-08-14 0:57 ` Greg-KH
2015-08-14 0:59 ` Nicholas A. Bellinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150814004543.GA23652@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=nab@linux-iscsi.org \
--cc=sagig@mellanox.com \
--cc=stable@vger.kernel.org \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.