From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stable-owner@vger.kernel.org>
Received: from mail.linuxfoundation.org ([140.211.169.12]:59178 "EHLO
	mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751996AbbHNA5H (ORCPT
	<rfc822;stable@vger.kernel.org>); Thu, 13 Aug 2015 20:57:07 -0400
Date: Thu, 13 Aug 2015 17:57:06 -0700
From: Greg-KH <gregkh@linuxfoundation.org>
To: "Nicholas A. Bellinger" <nab@linux-iscsi.org>
Cc: target-devel <target-devel@vger.kernel.org>,
	stable <stable@vger.kernel.org>,
	Sagi Grimberg <sagig@mellanox.com>
Subject: Re: [PATCH-v3.10.y] iscsi-target: Fix iscsit_start_kthreads failure
 OOPs
Message-ID: <20150814005706.GA21933@kroah.com>
References: <1439496730-18376-1-git-send-email-nab@linux-iscsi.org>
 <1439496730-18376-2-git-send-email-nab@linux-iscsi.org>
 <20150814004543.GA23652@kroah.com>
 <1439513306.7906.1.camel@haakon3.risingtidesystems.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1439513306.7906.1.camel@haakon3.risingtidesystems.com>
Sender: stable-owner@vger.kernel.org
List-ID: <stable.vger.kernel.org>

On Thu, Aug 13, 2015 at 05:48:26PM -0700, Nicholas A. Bellinger wrote:
> On Thu, 2015-08-13 at 17:45 -0700, Greg-KH wrote:
> > On Thu, Aug 13, 2015 at 08:12:10PM +0000, Nicholas A. Bellinger wrote:
> > > From: Nicholas Bellinger <nab@linux-iscsi.org>
> > > 
> > > This patch fixes a regression introduced with the following commit
> > > in v4.0-rc1 code, where a iscsit_start_kthreads() failure triggers
> > > a NULL pointer dereference OOPs:
> > > 
> > >     commit 88dcd2dab5c23b1c9cfc396246d8f476c872f0ca
> > >     Author: Nicholas Bellinger <nab@linux-iscsi.org>
> > >     Date:   Thu Feb 26 22:19:15 2015 -0800
> > > 
> > >         iscsi-target: Convert iscsi_thread_set usage to kthread.h
> > > 
> > > To address this bug, move iscsit_start_kthreads() immediately
> > > preceeding the transmit of last login response, before signaling
> > > a successful transition into full-feature-phase within existing
> > > iscsi_target_do_tx_login_io() logic.
> > > 
> > > This ensures that no target-side resource allocation failures can
> > > occur after the final login response has been successfully sent.
> > > 
> > > Also, it adds a iscsi_conn->rx_login_comp to allow the RX thread
> > > to sleep to prevent other socket related failures until the final
> > > iscsi_post_login_handler() call is able to complete.
> > > 
> > >     Issue DAT-3610
> > > 
> > > Change-Id: Ie41cd45dba698d4984ca711a56e4ffd3bb32ca6d
> > 
> > What is that here for?  
> > 
> 
> Ugh sorry, forgot to strip off these internal tags.
> 
> > I need to know the git commit id in Linus's tree, I guess I have to go
> > dig it out now...
> 
> That would be:
> 
>   commit e54198657b65625085834847ab6271087323ffea
>   Author: Nicholas Bellinger <nab@linux-iscsi.org>
>   Date:   Wed Jul 22 23:14:19 2015 -0700
> 
>       iscsi-target: Fix iscsit_start_kthreads failure OOPs

Ah crap, I picked e54198657b65625085834847ab6271087323ffea.  Let me go
delete the patches I just queued up and try it again...

ugh...