All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [v2 5/6] spi: cadence_qspi: fix base trigger address & transfer start address
Date: Fri, 14 Aug 2015 03:56:58 +0200	[thread overview]
Message-ID: <201508140356.58557.marex@denx.de> (raw)
In-Reply-To: <55CD46CA.903@st.com>

On Friday, August 14, 2015 at 03:39:22 AM, vikas wrote:
> Hi Marek,
> 
> On 08/13/2015 06:04 PM, Marek Vasut wrote:
> > On Friday, August 14, 2015 at 02:37:53 AM, vikas wrote:
> >> Hi,
> >> 
> >> On 08/13/2015 03:48 PM, Marek Vasut wrote:
> >>> On Thursday, August 13, 2015 at 11:36:31 PM, vikas wrote:
> >>>> Hi Marek,
> >>> 
> >>> Hi!
> >>> 
> >>>> On 08/13/2015 09:42 AM, vikasm wrote:
> >>>>> Hi Marek,
> >>>>> 
> >>>>> On 08/12/2015 07:15 PM, Marek Vasut wrote:
> >>>>>> On Thursday, July 16, 2015 at 04:27:33 AM, Vikas Manocha wrote:
> >>>>>>> This patch is to separate the base trigger from the read/write
> >>>>>>> transfer start addresses.
> >>>>>> 
> >>>>>> This patch breaks the QSPI support on SoCFPGA.
> >>>>> 
> >>>>> ok, can you please try to debug the issue. Logically this patch looks
> >>>>> good to me unless there is something specific to socfpga.
> >>>> 
> >>>> One quick check, can you test if it works on reverting the trigger
> >>>> base in arch/arm/dts/socfpga.dtsi from <0x00000000 0x0010> to
> >>>> <0xffa00000 0x1000>.
> >>> 
> >>> Can you please spin V3 of the patchset first, one which omits the buggy
> >>> bits, so I can test it on a more final form of the patches ? Please
> >>> keep me on CC, I'll test it then.
> >> 
> >> Once i add sram level test patches, i would not be able to test it on my
> >> platform. This particular issue is pending for long time. I suggest to
> >> debug (at least with above mentioned quick test) this particular
> >> issue/patch with current version v2. There is only minor change (format
> >> string) in this patch for v3.
> > 
> > That's fine, just send the V3 as RFT and I'll check it.
> 
> If this patch is not debugged, there is no major significance of this
> patchset. I would appreciate if you do some test with current v2.

I stop here for today and will get back to this in a few days again.
Please send V3 until then, I don't want to dig in old/broken code.

Best regards,
Marek Vasut

  reply	other threads:[~2015-08-14  1:56 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-16  2:27 [U-Boot] [v2 0/6] spi: cadence_qspi: optimize & fix indirect rd-writes Vikas Manocha
2015-07-16  2:27 ` [U-Boot] [v2 1/6] spi: cadence_qspi: move trigger base configuration in init Vikas Manocha
2015-08-13  2:07   ` Marek Vasut
2015-08-13 15:50     ` vikasm
2015-08-13 17:35       ` Marek Vasut
2015-08-13 19:05         ` vikasm
2015-08-14  1:24         ` vikas
2015-08-14  1:43           ` Marek Vasut
2015-08-14  1:44             ` vikas
2015-08-14  1:55               ` Marek Vasut
2015-07-16  2:27 ` [U-Boot] [v2 2/6] spi: cadence_qspi: remove sram polling from flash read Vikas Manocha
2015-08-13  2:09   ` Marek Vasut
2015-08-13 16:27     ` vikasm
2015-08-13 17:33       ` Marek Vasut
2015-08-13 19:49         ` vikas
2015-08-13 20:35           ` Marek Vasut
2015-08-13 21:04             ` vikas
2015-08-13 22:47               ` Marek Vasut
2015-08-13 23:18                 ` vikas
2015-08-13 23:46                   ` Marek Vasut
2015-08-14  0:26                     ` vikas
2015-08-14  0:44                       ` Marek Vasut
2015-08-14  0:46                         ` vikas
2015-08-14  1:03                           ` Marek Vasut
2015-08-14  1:05                             ` vikas
2015-08-14  3:54                               ` Marek Vasut
2015-07-16  2:27 ` [U-Boot] [v2 3/6] spi: cadence_qspi: remove sram polling from flash write Vikas Manocha
2015-08-13  2:11   ` Marek Vasut
2015-08-13 16:30     ` vikasm
2015-08-13 17:34       ` Marek Vasut
2015-07-16  2:27 ` [U-Boot] [v2 4/6] spi: cadence_qspi: fix indirect read/write start address Vikas Manocha
2015-07-16  2:27 ` [U-Boot] [v2 5/6] spi: cadence_qspi: fix base trigger address & transfer " Vikas Manocha
2015-08-13  2:15   ` Marek Vasut
2015-08-13 16:42     ` vikasm
2015-08-13 21:36       ` vikas
2015-08-13 22:48         ` Marek Vasut
2015-08-14  0:37           ` vikas
2015-08-14  1:04             ` Marek Vasut
2015-08-14  1:39               ` vikas
2015-08-14  1:56                 ` Marek Vasut [this message]
2015-08-14  2:14                   ` Vikas MANOCHA
2015-07-16  2:27 ` [U-Boot] [v2 6/6] spi: cadence_qspi: get fifo width from device tree Vikas Manocha

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201508140356.58557.marex@denx.de \
    --to=marex@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.