From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexandre Belloni Subject: Re: [PATCH v2 2/6] rtc: omap: Add external clock enabling support Date: Fri, 14 Aug 2015 10:29:35 +0200 Message-ID: <20150814082935.GF22269@piout.net> References: <1439198906-31189-1-git-send-email-j-keerthy@ti.com> <1439198906-31189-3-git-send-email-j-keerthy@ti.com> <55CB99C2.7010007@ti.com> <20150812201636.GJ3411@piout.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Paul Walmsley Cc: Keerthy , Keerthy , tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org, linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, pawel.moll-5wv7dgnIgG8@public.gmane.org, galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org, akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org, johan-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, grygorii.strashko-l0cyMroinI0@public.gmane.org, rtc-linux-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org, bcousson-rdvid1DuHRBWk0Htik3J/w@public.gmane.org, nm-l0cyMroinI0@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, t-kristo-l0cyMroinI0@public.gmane.org List-Id: linux-omap@vger.kernel.org On 13/08/2015 at 20:17:23 +0000, Paul Walmsley wrote : > > I'd say that I don't really care. I'd say the best would be to make a > > decision based on clock-accuracy but maybe that is an information you > > don't have yet. Anyway, this could be added at a later date. > > Either the clock mux logic is glitchless, in which case the RTC is likely > to lose at least 31 microseconds per switch; or it's not glitchless, in > which case it's unsafe to switch the RTC clock source while the clock > isn't gated. Keerthy, before submitting this patch for merging, I'd > suggest consulting your hardware folks to figure out which case it is. > Don't take me wrong, your point is perfectly valid. I was just saying that I didn't care what was done in the driver. Obviously, this has to match what is best from a hardware point of view. But since we agreed on the DT bindings, I'd say that we can still adjust the driver later. -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.free-electrons.com (down.free-electrons.com. [37.187.137.238]) by gmr-mx.google.com with ESMTP id gt9si38290wib.2.2015.08.14.01.29.36 for ; Fri, 14 Aug 2015 01:29:36 -0700 (PDT) Date: Fri, 14 Aug 2015 10:29:35 +0200 From: Alexandre Belloni To: Paul Walmsley Cc: Keerthy , Keerthy , tony@atomide.com, linux-omap@vger.kernel.org, pawel.moll@arm.com, galak@codeaurora.org, akpm@linux-foundation.org, johan@kernel.org, grygorii.strashko@ti.com, rtc-linux@googlegroups.com, bcousson@baylibre.com, nm@ti.com, devicetree@vger.kernel.org, t-kristo@ti.com Subject: [rtc-linux] Re: [PATCH v2 2/6] rtc: omap: Add external clock enabling support Message-ID: <20150814082935.GF22269@piout.net> References: <1439198906-31189-1-git-send-email-j-keerthy@ti.com> <1439198906-31189-3-git-send-email-j-keerthy@ti.com> <55CB99C2.7010007@ti.com> <20150812201636.GJ3411@piout.net> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 In-Reply-To: Reply-To: rtc-linux@googlegroups.com List-ID: List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , On 13/08/2015 at 20:17:23 +0000, Paul Walmsley wrote : > > I'd say that I don't really care. I'd say the best would be to make a > > decision based on clock-accuracy but maybe that is an information you > > don't have yet. Anyway, this could be added at a later date. > > Either the clock mux logic is glitchless, in which case the RTC is likely > to lose at least 31 microseconds per switch; or it's not glitchless, in > which case it's unsafe to switch the RTC clock source while the clock > isn't gated. Keerthy, before submitting this patch for merging, I'd > suggest consulting your hardware folks to figure out which case it is. > Don't take me wrong, your point is perfectly valid. I was just saying that I didn't care what was done in the driver. Obviously, this has to match what is best from a hardware point of view. But since we agreed on the DT bindings, I'd say that we can still adjust the driver later. -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com -- -- You received this message because you are subscribed to "rtc-linux". Membership options at http://groups.google.com/group/rtc-linux . Please read http://groups.google.com/group/rtc-linux/web/checklist before submitting a driver. --- You received this message because you are subscribed to the Google Groups "rtc-linux" group. To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com. For more options, visit https://groups.google.com/d/optout.