From: Dan Carpenter <dan.carpenter@oracle.com>
To: Andrey Shvetsov <andrey.shvetsov.ml@gmail.com>
Cc: Joe Perches <joe@perches.com>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 07/19] staging: most: Remove unnecessary externs
Date: Fri, 14 Aug 2015 13:50:26 +0300 [thread overview]
Message-ID: <20150814105026.GC4496@mwanda> (raw)
In-Reply-To: <20150814083635.GA4193@arch.fritz.box>
On Fri, Aug 14, 2015 at 10:36:35AM +0200, Andrey Shvetsov wrote:
> On Mon, Aug 10, 2015 at 02:51:22PM -0700, Joe Perches wrote:
> > Using 'extern' is not necessary for function prototypes.
> >
> We use them to mark dependency inversions (callbacks).
> I thought about comments instead of, but I'm not sure what is worse.
I have never heard of anyone using the extern keyword to mean that
before so I feel like it doesn't work as a "putting extern means the
code documents itself".
regards,
dan carpenter
next prev parent reply other threads:[~2015-08-14 10:50 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-10 21:51 [PATCH 00/19] staging: Remove unnecessary externs Joe Perches
2015-08-10 21:51 ` Joe Perches
2015-08-10 21:51 ` Joe Perches
2015-08-10 21:51 ` [PATCH 01/19] staging: android: " Joe Perches
2015-08-10 21:51 ` [PATCH 02/19] staging: dgnc: " Joe Perches
2015-08-10 21:51 ` [PATCH 03/19] staging: fbtft: " Joe Perches
2015-08-10 21:51 ` [PATCH 04/19] staging: ft1000: " Joe Perches
2015-08-10 21:51 ` [PATCH 05/19] staging: iio: " Joe Perches
2015-08-11 18:43 ` Lars-Peter Clausen
2015-08-15 19:57 ` Jonathan Cameron
2015-08-15 20:05 ` Lars-Peter Clausen
2015-08-15 20:33 ` Jonathan Cameron
2015-08-10 21:51 ` [PATCH 06/19] staging: lustre: " Joe Perches
2015-08-10 21:51 ` [PATCH 07/19] staging: most: " Joe Perches
2015-08-14 8:36 ` Andrey Shvetsov
2015-08-14 10:50 ` Dan Carpenter [this message]
2015-08-10 21:51 ` [PATCH 08/19] staging: mt29f_spinand: " Joe Perches
2015-08-10 21:51 ` [PATCH 09/19] staging: netlogic: " Joe Perches
2015-08-10 21:51 ` [PATCH 10/19] staging: nvec: " Joe Perches
2015-08-10 21:51 ` [PATCH 11/19] staging: octeon: " Joe Perches
2015-08-10 22:16 ` David Daney
2015-08-10 21:51 ` [PATCH 12/19] staging: olpc_dcon: " Joe Perches
2015-08-10 21:51 ` [PATCH 13/19] staging: rtl8188eu: " Joe Perches
2015-08-10 21:51 ` [PATCH 14/19] staging: rtl8192e: " Joe Perches
2015-08-10 21:51 ` [PATCH 15/19] staging: rtl8192u: " Joe Perches
2015-08-10 21:51 ` [PATCH 16/19] staging: rtl8712: " Joe Perches
2015-08-10 21:51 ` [PATCH 17/19] staging: speakup: " Joe Perches
2015-08-10 21:51 ` [PATCH 18/19] staging: wilc1000: " Joe Perches
2015-08-10 21:51 ` [PATCH 19/19] staging: xgifb: " Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150814105026.GC4496@mwanda \
--to=dan.carpenter@oracle.com \
--cc=andrey.shvetsov.ml@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.