From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thierry Reding Subject: Re: [PATCH 12/13] drm/armada: Use drm_crtc_vblank_*() API Date: Fri, 14 Aug 2015 16:24:01 +0200 Message-ID: <20150814142359.GA23526@ulmo.nvidia.com> References: <1439391635-29166-1-git-send-email-thierry.reding@gmail.com> <1439391635-29166-12-git-send-email-thierry.reding@gmail.com> <20150814135915.GW7557@n2100.arm.linux.org.uk> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0117470521==" Return-path: Received: from mail-pa0-f41.google.com (mail-pa0-f41.google.com [209.85.220.41]) by gabe.freedesktop.org (Postfix) with ESMTPS id 24E236E6B1 for ; Fri, 14 Aug 2015 07:25:01 -0700 (PDT) Received: by pacgr6 with SMTP id gr6so61063622pac.2 for ; Fri, 14 Aug 2015 07:25:00 -0700 (PDT) In-Reply-To: <20150814135915.GW7557@n2100.arm.linux.org.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Russell King - ARM Linux Cc: Daniel Vetter , dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============0117470521== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="/04w6evG8XlLl3ft" Content-Disposition: inline --/04w6evG8XlLl3ft Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Aug 14, 2015 at 02:59:16PM +0100, Russell King - ARM Linux wrote: > On Wed, Aug 12, 2015 at 05:00:34PM +0200, Thierry Reding wrote: > > From: Thierry Reding > >=20 > > Non-legacy drivers should only use this API to allow per-CRTC data to be > > eventually moved into struct drm_crtc. > >=20 > > Cc: Russell King > > Signed-off-by: Thierry Reding >=20 > What I don't like about the new APIs is that they lookup the CRTC number > by searching the crtc list on every call to them. If that's going to be > fixed, then I'm happy with this change, but if it's going to remain for > a significant time, I'm really not happy. This is a temporary measure. The goal is to eventually split off the VBLANK data into a per-CRTC structure, at which point there will be no longer any need for the CRTC index. Thierry --/04w6evG8XlLl3ft Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAABCAAGBQJVzfn9AAoJEN0jrNd/PrOhsIgP/00YP5ilQgnnJ6btllE7UKqn Ur5UNvHgrYeTbM+wqPRkFWzLOlOOZk/QFqqYnBPPyUV1ctTejyM2WDz95yyJg0dT 3FFs/8wJ/f8it/zJUtay+k3Ri9MSkBSXeqD3m1RS1K5eHw3nG5n69mlkHQ1sz7SQ q0mxVtXAVH8Cch/2E0W/ev6ZmBeU7Z3ylDH75D3OqSggPhbRsrus6AoCRT8Dvvw8 3SojnHsM6bIS1zJFPw3I21gaim5KHdzNMKHWcM7I3I5QXDz3iDW3GOoupU+eaK79 DoIEPzfYvi5AtQsHj8sjEiE7zXMJ36el3kI6NsrcBDLlcbKNTc96LjIfOGXvLmCL SMwULNCDE5dwr+RdAtbOc+k90rPuN37rcHqKDrQ8ulxTW+IL5Hwti62HysgMnPIh UBrqv2OS6YS01hM8pEIp4ha+bUHrLu6+SXjDbK3QX6L/1WrUcdhgsK/VPcPln8kR afcFECuz1UWxUmB+r5RexP+LuDO99s5Ra1P30vNwIt3ZHjoRW5ebXjt6sdeUa+0J 23ODWhueYGsMa/aZc8eUqqVwCmbaAjQqWqsFKLZ+K3tYud6ds+UO1vKQ+LuUIYbz EHUwaZOj6C890R9b9DnaUro13mdHf1sA60fUNc+HLy7+G2GueZVqdDZiFJE04lmp jRvG9elaWN8xGfA/Ku6T =YBwg -----END PGP SIGNATURE----- --/04w6evG8XlLl3ft-- --===============0117470521== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0 cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK --===============0117470521==--