From: Matt Fleming <matt@codeblueprint.co.uk>
To: "Zhang, Jonathan Zhixiong" <zjzhang@codeaurora.org>
Cc: Ingo Molnar <mingo@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
"H. Peter Anvin" <hpa@zytor.com>,
linux-kernel@vger.kernel.org, linux-efi@vger.kernel.org,
Matt Fleming <matt.fleming@intel.com>,
Ard Biesheuvel <ard.biesheuvel@linaro.org>,
Catalin Marinas <catalin.marinas@arm.com>,
Hanjun Guo <hanjun.guo@linaro.org>,
Will Deacon <will.deacon@arm.com>
Subject: Re: [PATCH 1/2] arm64: apei: implement arch_apei_get_mem_attributes()
Date: Fri, 14 Aug 2015 20:12:20 +0100 [thread overview]
Message-ID: <20150814191220.GA7556@codeblueprint.co.uk> (raw)
In-Reply-To: <55CE399F.1030108@codeaurora.org>
On Fri, 14 Aug, at 11:55:27AM, Zhang, Jonathan Zhixiong wrote:
>
> >Also, this doesn't look like a small function - why is it inlined?
> The function grew a bit after its first version. Since it is on the
> fence of not being a small function, I did not change it to out of
> the line. I will move it to arch/arm64/kernel/acpi.c guarded by
> CONFIG_ACPI_APEI instead of having to create a very small new file,
> if there is no opposition.
Please keep Will in the loop (now Cc'd) since he originally suggested
moving this to a header file and marking it static inline.
--
Matt Fleming, Intel Open Source Technology Center
next prev parent reply other threads:[~2015-08-14 19:12 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-12 16:17 [GIT PULL 0/2] EFI changes for v4.3 (part two) Matt Fleming
2015-08-12 16:17 ` Matt Fleming
2015-08-12 16:17 ` [PATCH 1/2] arm64: apei: implement arch_apei_get_mem_attributes() Matt Fleming
2015-08-13 8:22 ` Ingo Molnar
[not found] ` <20150813082207.GB14610-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2015-08-14 18:55 ` Zhang, Jonathan Zhixiong
2015-08-14 18:55 ` Zhang, Jonathan Zhixiong
2015-08-14 19:12 ` Matt Fleming [this message]
2015-08-12 16:17 ` [PATCH 2/2] acpi, apei: use appropriate pgprot_t to map GHES memory Matt Fleming
[not found] ` <1439396234-22863-3-git-send-email-matt-mF/unelCI9GS6iBeEJttW/XRex20P6io@public.gmane.org>
2015-08-13 8:19 ` Ingo Molnar
2015-08-13 8:19 ` Ingo Molnar
[not found] ` <20150813081917.GA14610-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2015-08-13 9:24 ` Matt Fleming
2015-08-13 9:24 ` Matt Fleming
[not found] ` <20150813092432.GA2797-mF/unelCI9GS6iBeEJttW/XRex20P6io@public.gmane.org>
2015-08-13 11:14 ` Will Deacon
2015-08-13 11:14 ` Will Deacon
[not found] ` <20150813111422.GE10280-5wv7dgnIgG8@public.gmane.org>
2015-08-14 19:09 ` Zhang, Jonathan Zhixiong
2015-08-14 19:09 ` Zhang, Jonathan Zhixiong
-- strict thread matches above, loose matches on Subject: below --
2015-09-04 13:11 [GIT PULL 0/2] EFI changes for v4.3 (part two) Matt Fleming
2015-09-04 13:11 ` [PATCH 1/2] arm64: apei: Implement arch_apei_get_mem_attributes() Matt Fleming
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150814191220.GA7556@codeblueprint.co.uk \
--to=matt@codeblueprint.co.uk \
--cc=ard.biesheuvel@linaro.org \
--cc=catalin.marinas@arm.com \
--cc=hanjun.guo@linaro.org \
--cc=hpa@zytor.com \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matt.fleming@intel.com \
--cc=mingo@kernel.org \
--cc=tglx@linutronix.de \
--cc=will.deacon@arm.com \
--cc=zjzhang@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.