All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] i2c: adding driver for pxa27x, pxa3xx, pxa25x
Date: Sun, 16 Aug 2015 04:12:02 +0200	[thread overview]
Message-ID: <201508160412.02661.marex@denx.de> (raw)
In-Reply-To: <1439687595.4218.29.camel@ziswiler.com>

On Sunday, August 16, 2015 at 03:13:15 AM, Marcel Ziswiler wrote:
> On Sun, 2015-08-16 at 02:57 +0200, Marek Vasut wrote:
> > > Apart from the missing commit message.
> > > 
> > > Signed-off-by: Marcel Ziswiler <marcel@ziswiler.com>
> > 
> > I think you're misunderstanding the meaning of a SoB line here, the
> > SoB
> > line is a certificate of origin. You didn't write the driver and/or
> > you
> > didn't make changes to it, so you don't place your certificate on it
> > 
> > :)
> 
> Yeah, it's kind of late. Should have been an Acked-by of course, sorry.

I can understand that :)

> > > Tested-by: Marcel Ziswiler <marcel@ziswiler.com>
> > 
> > This one is of course good.
> > 
> > > Tested-on: Colibri PXA270 V1.2C, V1.2D, V2.2B, V2.4A on Colibri
> > 
> > Is this some kind of a newly invented tag ? :-)
> 
> Well, others have been using that one on and off for a while. So at
> least I am not the inventor (;-p).

Heh :)

> > > Evaluation Board V3.1A
> > > Note: While power I2C works on the older V1.2C version it does not
> > 
> > seem
> > 
> > > to work on any of the newer ones but this might just be a pin
> > 
> > muxing
> > 
> > > resp. missing pull up issue.
> > 
> > Very nice. Btw. how do you bootstrap those modules, do you use that
> > OpenPXA
> > OBM or OBM2 or something else entirely ?
> 
> No, I never used any of that crap.

Well sorry it wasn't to your liking ... ;-)

> Just purely U-Boot even on the
> PXA3xx but the PXA270 being just a regular NOR beast is really nothing
> special. Just using ye olde BDI2000 if things go awry. Unfortunately my
> PXA3xx U-Boot NAND SPL stuff never made it mainline and you since
> dropped PXA3xx support entirely. If I ever get some precious time I
> might actually re-add those again especially now with Marvell having
> committed to keep selling us PXA320 chips to 2020.

There is some very rudimentary SPL support in the u-boot-pxa, but it's
really old.

Best regards,
Marek Vasut

      reply	other threads:[~2015-08-16  2:12 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-12 18:43 [U-Boot] [PATCH] i2c: adding driver for pxa27x, pxa3xx, pxa25x Andrew Ruder
2015-08-12 19:34 ` Marek Vasut
2015-08-12 20:19   ` Andrew Ruder
2015-08-12 20:34     ` Marek Vasut
2015-08-21 12:04   ` Andrew Ruder
2015-08-16  0:34 ` Marcel Ziswiler
2015-08-16  0:57   ` Marek Vasut
2015-08-16  1:13     ` Marcel Ziswiler
2015-08-16  2:12       ` Marek Vasut [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201508160412.02661.marex@denx.de \
    --to=marex@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.