All of lore.kernel.org
 help / color / mirror / Atom feed
From: NeilBrown <neilb@suse.com>
To: Greg KH <greg@kroah.com>
Cc: stable@vger.kernel.org, linux-raid <linux-raid@vger.kernel.org>,
	GuoQing Jiang <gqjiang@suse.com>,
	Goldwyn Rodrigues <rgoldwyn@suse.com>,
	lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH stable] md/bitmap: return an error when bitmap superblock is corrupt.
Date: Mon, 17 Aug 2015 10:33:41 +1000	[thread overview]
Message-ID: <20150817103341.1b444214@noble> (raw)
In-Reply-To: <20150814172351.GB17745@kroah.com>

On Fri, 14 Aug 2015 10:23:51 -0700 Greg KH <greg@kroah.com> wrote:

> On Fri, Aug 14, 2015 at 05:04:21PM +1000, NeilBrown wrote:
> > 
> > commit b97e92574c0bf335db1cd2ec491d8ff5cd5d0b49 upstream
> >     Use separate bitmaps for each nodes in the cluster
> > 
> > bitmap_read_sb() validates the bitmap superblock that it reads in.
> > If it finds an inconsistency like a bad magic number or out-of-range
> > version number, it prints an error and returns, but it incorrectly
> > returns zero, so the array is still assembled with the (invalid) bitmap.
> > 
> > This means it could try to use a bitmap with a new version number which
> > it therefore does not understand.
> > 
> > This bug was introduced in 3.5 and fix as part of a larger patch in 4.1.
> > So the patch is suitable for any -stable kernel in that range.
> > 
> > Fixes: 27581e5ae01f ("md/bitmap: centralise allocation of bitmap file pages.")
> > Cc: stable@vger.kernel.org (v3.5..v4.1)
> 
> b97e92574c0 is in 4.1, so do you mean (v3.5..v4.0) here?
> 

Yes,  I did.  Thanks!

v3.5..v4.0.

NeilBrown

  reply	other threads:[~2015-08-17  0:33 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-14  7:04 [PATCH stable] md/bitmap: return an error when bitmap superblock is corrupt NeilBrown
2015-08-14 17:23 ` Greg KH
2015-08-17  0:33   ` NeilBrown [this message]
2015-08-14 17:25 ` Patch "md/bitmap: return an error when bitmap superblock is corrupt." has been added to the 3.10-stable tree gregkh
2015-08-14 17:25   ` gregkh
2015-08-14 17:25 ` Patch "md/bitmap: return an error when bitmap superblock is corrupt." has been added to the 3.14-stable tree gregkh
2015-08-14 17:25   ` gregkh
2015-08-25 10:19 ` [PATCH stable] md/bitmap: return an error when bitmap superblock is corrupt Luis Henriques
2015-08-25 10:19   ` Luis Henriques

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150817103341.1b444214@noble \
    --to=neilb@suse.com \
    --cc=gqjiang@suse.com \
    --cc=greg@kroah.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-raid@vger.kernel.org \
    --cc=rgoldwyn@suse.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.