From: Dan Carpenter <dan.carpenter@oracle.com>
To: Chaehyun Lim <chaehyun.lim@gmail.com>
Cc: gregkh@linuxfoundation.org, rachel.kim@atmel.com,
dean.lee@atmel.com, chris.park@atmel.com,
devel@driverdev.osuosl.org, linux-wireless@vger.kernel.org,
johnny.kim@atmel.com
Subject: Re: [PATCH 3/4] staging: wilc1000: remove WILC_ErrNo
Date: Mon, 17 Aug 2015 17:23:50 +0300 [thread overview]
Message-ID: <20150817142350.GG5558@mwanda> (raw)
In-Reply-To: <1439819071-30000-3-git-send-email-chaehyun.lim@gmail.com>
On Mon, Aug 17, 2015 at 10:44:30PM +0900, Chaehyun Lim wrote:
> WILC_ErrNo is replaced by s32, then WILC_ErrNo typedef is removed.
>
s32 is a weirdo type. You should only specify the number of bit when it
is something required by the hardware. Just use int.
regards,
dan carpenter
next prev parent reply other threads:[~2015-08-17 14:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-17 13:44 [PATCH 1/4] staging: wilc1000: delete wilc_log.h Chaehyun Lim
2015-08-17 13:44 ` [PATCH 2/4] staging: wilc1000: delete wilc_osconfig.h Chaehyun Lim
2015-08-17 19:52 ` Greg KH
2015-08-17 13:44 ` [PATCH 3/4] staging: wilc1000: remove WILC_ErrNo Chaehyun Lim
2015-08-17 14:23 ` Dan Carpenter [this message]
2015-08-17 13:44 ` [PATCH 4/4] staging: wilc1000: return -EINVAL for invalid argument checking Chaehyun Lim
2015-08-17 19:53 ` Greg KH
2015-08-17 19:51 ` [PATCH 1/4] staging: wilc1000: delete wilc_log.h Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150817142350.GG5558@mwanda \
--to=dan.carpenter@oracle.com \
--cc=chaehyun.lim@gmail.com \
--cc=chris.park@atmel.com \
--cc=dean.lee@atmel.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=johnny.kim@atmel.com \
--cc=linux-wireless@vger.kernel.org \
--cc=rachel.kim@atmel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.