All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thierry Reding <thierry.reding@gmail.com>
To: Jonathan Richardson <jonathar@broadcom.com>
Cc: Tim Kryger <tim.kryger@gmail.com>,
	Dmitry Torokhov <dtor@google.com>,
	Anatol Pomazau <anatol@google.com>,
	Arun Ramamurthy <arun.ramamurthy@broadcom.com>,
	Scott Branden <sbranden@broadcom.com>,
	bcm-kernel-feedback-list <bcm-kernel-feedback-list@broadcom.com>,
	linux-kernel@vger.kernel.org, linux-pwm@vger.kernel.org
Subject: Re: [PATCH v9 1/2] pwm: kona: Modify settings application sequence
Date: Mon, 17 Aug 2015 16:25:43 +0200	[thread overview]
Message-ID: <20150817142542.GC6891@ulmo.nvidia.com> (raw)
In-Reply-To: <1434403262-24198-2-git-send-email-jonathar@broadcom.com>

[-- Attachment #1: Type: text/plain, Size: 880 bytes --]

On Mon, Jun 15, 2015 at 02:21:01PM -0700, Jonathan Richardson wrote:
> Update the driver so that settings are applied in accordance with the
> most recent version of the hardware spec.  The revised sequence clears
> the trigger bit, waits 400ns, writes settings, sets the trigger bit,
> and waits another 400ns.  This corrects an issue where occasionally a
> requested change was not properly reflected in the PWM output.
> 
> Reviewed-by: Arun Ramamurthy <arunrama@broadcom.com>
> Reviewed-by: Scott Branden <sbranden@broadcom.com>
> Tested-by: Scott Branden <sbranden@broadcom.com>
> Reviewed-by: Tim Kryger <tim.kryger@gmail.com>
> Signed-off-by: Jonathan Richardson <jonathar@broadcom.com>
> ---
>  drivers/pwm/pwm-bcm-kona.c |   47 +++++++++++++++++++++++++++++++++++---------
>  1 file changed, 38 insertions(+), 9 deletions(-)

Applied, thanks.

Thierry

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

  parent reply	other threads:[~2015-08-17 14:26 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-15 21:21 [PATCH v9 0/2] Fix bugs in kona pwm driver and pwm core Jonathan Richardson
2015-06-15 21:21 ` Jonathan Richardson
2015-06-15 21:21 ` [PATCH v9 1/2] pwm: kona: Modify settings application sequence Jonathan Richardson
2015-06-15 21:21   ` Jonathan Richardson
2015-07-02 23:36   ` Jonathan Richardson
2015-07-02 23:36     ` Jonathan Richardson
2015-08-17 14:25   ` Thierry Reding [this message]
2015-06-15 21:21 ` [PATCH v9 2/2] pwm: core: Set enable state properly on failed call to enable Jonathan Richardson
2015-06-15 21:21   ` Jonathan Richardson
2015-06-15 23:22   ` Jonathan Richardson
2015-06-15 23:22     ` Jonathan Richardson
2015-08-17 14:31     ` Thierry Reding
2015-10-16 18:27       ` Jonathan Richardson
2015-10-16 18:27         ` Jonathan Richardson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150817142542.GC6891@ulmo.nvidia.com \
    --to=thierry.reding@gmail.com \
    --cc=anatol@google.com \
    --cc=arun.ramamurthy@broadcom.com \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=dtor@google.com \
    --cc=jonathar@broadcom.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pwm@vger.kernel.org \
    --cc=sbranden@broadcom.com \
    --cc=tim.kryger@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.