All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johan Hovold <johan@kernel.org>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: Philipp Hachtmann <hachti@hachti.de>,
	johan@kernel.org, linux-usb@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] USB: symbolserial: Use usb_get_serial_port_data
Date: Mon, 17 Aug 2015 20:01:22 +0200	[thread overview]
Message-ID: <20150817180122.GJ7053@localhost> (raw)
In-Reply-To: <20150817160615.GB6477@kroah.com>

On Mon, Aug 17, 2015 at 09:06:15AM -0700, Greg Kroah-Hartman wrote:
> On Mon, Aug 17, 2015 at 05:31:46PM +0200, Philipp Hachtmann wrote:
> > The driver used usb_get_serial_data(port->serial) which compiled but resulted
> > in a NULL pointer being returned (and subsequently used). I did not go deeper
> > into this but I guess this is a regression.
> > 
> > Signed-off-by: Philipp Hachtmann <hachti@hachti.de>
> > ---
> >  drivers/usb/serial/symbolserial.c | 6 +++---
> >  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> Doh, obviously no one has used this driver in a long time, thanks for
> these patches...

Wow...

> Johan, mind if I take these directly?

Please do.

This one should be tagged:

Fixes: a85796ee5149 ("USB: symbolserial: move private-data allocation to
port_probe")
Cc: stable <stable@vger.kernel.org>	# v3.10

And for both patches:

Acked-by: Johan Hovold <johan@kernel.org>

Thanks,
Johan

  reply	other threads:[~2015-08-17 18:01 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-17 15:31 [PATCH 0/2] USB: symbolserial: Fix OOPS (regression) and data length Philipp Hachtmann
2015-08-17 15:31 ` [PATCH 1/2] USB: symbolserial: Use usb_get_serial_port_data Philipp Hachtmann
2015-08-17 16:06   ` Greg KH
2015-08-17 18:01     ` Johan Hovold [this message]
2015-08-17 15:31 ` [PATCH 2/2] USB: symbolserial: Correct transferred data size Philipp Hachtmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150817180122.GJ7053@localhost \
    --to=johan@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=hachti@hachti.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.