From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53163) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZRcMS-0000I8-IQ for qemu-devel@nongnu.org; Tue, 18 Aug 2015 04:35:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZRcMQ-000556-Fk for qemu-devel@nongnu.org; Tue, 18 Aug 2015 04:35:12 -0400 Received: from hall.aurel32.net ([2001:bc8:30d7:100::1]:37392) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZRcMQ-00054U-AB for qemu-devel@nongnu.org; Tue, 18 Aug 2015 04:35:10 -0400 Date: Tue, 18 Aug 2015 10:35:06 +0200 From: Aurelien Jarno Message-ID: <20150818083506.GA20101@aurel32.net> References: <1439840320-20897-1-git-send-email-rth@twiddle.net> <1439840320-20897-11-git-send-email-rth@twiddle.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1439840320-20897-11-git-send-email-rth@twiddle.net> Subject: Re: [Qemu-devel] [PATCH 10/17] tcg/optimize: do not remember garbage high bits for 32-bit ops List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Richard Henderson Cc: peter.maydell@linaro.org, qemu-devel@nongnu.org On 2015-08-17 12:38, Richard Henderson wrote: > From: Aurelien Jarno > > Now that we have real size changing ops, we don't need to mark high > bits of the destination as garbage. The goal of the optimizer is to > predict the value of the temps (and not of the registers) and do > simplifications when possible. The problem there is therefore not the > fact that those bits are not counted as garbage, but that a size > changing op is replaced by a move. > > This patch is basically a revert of 24666baf, including the changes that > have been made since then. > > Cc: Richard Henderson > Signed-off-by: Aurelien Jarno > --- > tcg/optimize.c | 41 +++++++++++------------------------------ > 1 file changed, 11 insertions(+), 30 deletions(-) Self NACK. This patch breaks things given !(def->flags & TCG_OPF_64BIT) doesn't necessary means 32-bit result, at least in the case of the call opcode. I'll try to send an updated patch which handles that correctly in the next days (and catch up on other QEMU things), I am currently busy with other free software stuff. -- Aurelien Jarno GPG: 4096R/1DDD8C9B aurelien@aurel32.net http://www.aurel32.net