All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Ronit Halder <ronit.crj@gmail.com>
Cc: thomas.petazzoni@free-electrons.com, devel@driverdev.osuosl.org,
	gregkh@linuxfoundation.org, noralf@tronnes.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging: fbtft: Fix iomem dereference
Date: Tue, 18 Aug 2015 11:57:31 +0300	[thread overview]
Message-ID: <20150818085731.GL5558@mwanda> (raw)
In-Reply-To: <1439880417-15675-1-git-send-email-ronit.crj@gmail.com>

On Tue, Aug 18, 2015 at 12:16:57PM +0530, Ronit Halder wrote:
> This patch fixes the warning generated by sparse
> "cast removes address space of expression" by using ioread16
> function insted of directly dereferencing I/O memory.
> 
> Signed-off-by: Ronit halder <ronit.crj@gmail.com>

Are these really iomem pointers?  A lot of drivers use a fake
screen_base which is just a buffer of normal memory.

regards,
dan carpenter


  reply	other threads:[~2015-08-18  8:57 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-18  6:46 [PATCH] Staging: fbtft: Fix iomem dereference Ronit Halder
2015-08-18  8:57 ` Dan Carpenter [this message]
2015-08-18 13:38   ` Ronit Halder

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150818085731.GL5558@mwanda \
    --to=dan.carpenter@oracle.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=noralf@tronnes.org \
    --cc=ronit.crj@gmail.com \
    --cc=thomas.petazzoni@free-electrons.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.