From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.free-electrons.com (down.free-electrons.com. [37.187.137.238]) by gmr-mx.google.com with ESMTP id x20si493029wia.0.2015.08.18.02.24.42 for ; Tue, 18 Aug 2015 02:24:42 -0700 (PDT) Date: Tue, 18 Aug 2015 11:21:52 +0200 From: Alexandre Belloni To: Gregory CLEMENT Cc: Alessandro Zummo , rtc-linux@googlegroups.com, Jason Cooper , Andrew Lunn , Sebastian Hesselbarth , Thomas Petazzoni , Ezequiel Garcia , linux-arm-kernel@lists.infradead.org, Maxime Ripard , Boris BREZILLON , Lior Amsalem , Tawfik Bayouk , Nadav Haklai Subject: [rtc-linux] Re: [PATCH] rtc: armada38x: Align RTC set time procedure with the official errata Message-ID: <20150818092152.GV22269@piout.net> References: <1438874328-31844-1-git-send-email-gregory.clement@free-electrons.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 In-Reply-To: <1438874328-31844-1-git-send-email-gregory.clement@free-electrons.com> Reply-To: rtc-linux@googlegroups.com List-ID: List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , On 06/08/2015 at 17:18:48 +0200, Gregory CLEMENT wrote : > From: Nadav Haklai > > According to the Armada38x functional errata FE-3124064, writing to > the RTC TIME register may fail. As a workaround, after writing to RTC > TIME register, issue a dummy write of 0x0 twice to the RTC Status > register. This is the updated implementation of the Errata that > eliminates the need of the long 100ms delay during the RTC set time > procedure. > > [gregory.clement@free-electrons.com]: removed the mutex and use the > spinlock again > > Signed-off-by: Nadav Haklai > Reviewed-by: Neta Zur Hershkovits > Signed-off-by: Gregory CLEMENT Applied, thanks. -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com -- -- You received this message because you are subscribed to "rtc-linux". Membership options at http://groups.google.com/group/rtc-linux . Please read http://groups.google.com/group/rtc-linux/web/checklist before submitting a driver. --- You received this message because you are subscribed to the Google Groups "rtc-linux" group. To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com. For more options, visit https://groups.google.com/d/optout. From mboxrd@z Thu Jan 1 00:00:00 1970 From: alexandre.belloni@free-electrons.com (Alexandre Belloni) Date: Tue, 18 Aug 2015 11:21:52 +0200 Subject: [PATCH] rtc: armada38x: Align RTC set time procedure with the official errata In-Reply-To: <1438874328-31844-1-git-send-email-gregory.clement@free-electrons.com> References: <1438874328-31844-1-git-send-email-gregory.clement@free-electrons.com> Message-ID: <20150818092152.GV22269@piout.net> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 06/08/2015 at 17:18:48 +0200, Gregory CLEMENT wrote : > From: Nadav Haklai > > According to the Armada38x functional errata FE-3124064, writing to > the RTC TIME register may fail. As a workaround, after writing to RTC > TIME register, issue a dummy write of 0x0 twice to the RTC Status > register. This is the updated implementation of the Errata that > eliminates the need of the long 100ms delay during the RTC set time > procedure. > > [gregory.clement at free-electrons.com]: removed the mutex and use the > spinlock again > > Signed-off-by: Nadav Haklai > Reviewed-by: Neta Zur Hershkovits > Signed-off-by: Gregory CLEMENT Applied, thanks. -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com