From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH for v4.2] Revert "drm/i915: Allow parsing of variable size child device entries from VBT" Date: Tue, 18 Aug 2015 14:15:47 +0300 Message-ID: <20150818111547.GI5176@intel.com> References: <1439890416-16826-1-git-send-email-jani.nikula@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTP id 015286EA46 for ; Tue, 18 Aug 2015 04:16:25 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1439890416-16826-1-git-send-email-jani.nikula@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Jani Nikula Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVHVlLCBBdWcgMTgsIDIwMTUgYXQgMTI6MzM6MzZQTSArMDMwMCwgSmFuaSBOaWt1bGEgd3Jv dGU6Cj4gVGhpcyByZXZlcnRzCj4gCj4gY29tbWl0IDA0N2ZlNmU2ZGI5MTYxZTY5MjcxZjU2ZGFh YWZkYWYyYWRkMDIzYjEKPiBBdXRob3I6IERhdmlkIFdlaW5laGFsbCA8ZGF2aWQud2VpbmVoYWxs QGxpbnV4LmludGVsLmNvbT4KPiBEYXRlOiAgIFR1ZSBBdWcgNCAxNjo1NTo1MiAyMDE1ICswMzAw Cj4gCj4gICAgIGRybS9pOTE1OiBBbGxvdyBwYXJzaW5nIG9mIHZhcmlhYmxlIHNpemUgY2hpbGQg ZGV2aWNlIGVudHJpZXMgZnJvbSBWQlQKPiAKPiBUaGF0IGNvbW1pdCBpcyBub3QgdmFsaWQgZm9y IHY0LjIsIGhvd2V2ZXIgaXQgd2lsbCBiZSB2YWxpZCBmb3IgdjQuMy4gSXQKPiB3YXMgc2ltcGx5 IHF1ZXVlZCB0b28gZWFybHkuCj4gCj4gVGhlIHJlZmVyZW5jZWQgcmVncmVzc2luZyBjb21taXQg aXMganVzdCBmaW5lIHVudGlsIHRoZSBzaXplIG9mIHN0cnVjdAo+IGNvbW1vbl9jaGlsZF9kZXZf Y29uZmlnIGNoYW5nZXMsIGFuZCB0aGF0IHdvbid0IGhhcHBlbiB1bnRpbAo+IHY0LjMuIEluZGVl ZCwgdGhlIGV4cGVjdGVkIHNpemUgY2hlY2tzIGhlcmUgcmVseSBvbiB0aGUgaW5jcmVhc2VkIHNp emUKPiBvZiB0aGUgc3RydWN0LCBicmVha2luZyBuZXcgcGxhdGZvcm1zLgo+IAo+IEZpeGVzOiAw NDdmZTZlNmRiOTEgKCJkcm0vaTkxNTogQWxsb3cgcGFyc2luZyBvZiB2YXJpYWJsZSBzaXplIGNo aWxkIGRldmljZSBlbnRyaWVzIGZyb20gVkJUIikKPiBDYzogRGFuaWVsIFZldHRlciA8ZGFuaWVs QGZmd2xsLmNoPgo+IENjOiBEYXZpZCBXZWluZWhhbGwgPGRhdmlkLndlaW5laGFsbEBsaW51eC5p bnRlbC5jb20+Cj4gQ2M6IFZpbGxlIFN5cmrDpGzDpCA8dmlsbGUuc3lyamFsYUBsaW51eC5pbnRl bC5jb20+Cj4gU2lnbmVkLW9mZi1ieTogSmFuaSBOaWt1bGEgPGphbmkubmlrdWxhQGludGVsLmNv bT4KClJldmlld2VkLWJ5OiBWaWxsZSBTeXJqw6Rsw6QgPHZpbGxlLnN5cmphbGFAbGludXguaW50 ZWwuY29tPgoKPiAKPiAtLS0KPiAKPiBUaGVyZSB3YXMgYW5vdGhlciBwYXRjaCBmcm9tIERhdmlk IGluY3JlYXNpbmcgdGhlIHNpemUgb2YgdGhlIHN0cnVjdAo+IFsxXSwgYnV0IHRoYXQgdGhlbiBy ZWdyZXNzZXMgc2R2byBtYXBwaW5nIHBhcnNpbmcuIEl0J3MgdGhlIHNpbXBsZXN0IHRvCj4ganVz dCByZXZlcnQgYW5kIGZpeCB0aGlzIHVwIHByb3Blcmx5IGZvciB2NC4zLgo+IAo+IFsxXSBodHRw Oi8vbWlkLmdtYW5lLm9yZy8yMDE1MDgxMzEzMTQxNS5HTzYxNTBAYm9vbQo+IC0tLQo+ICBkcml2 ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9iaW9zLmMgfCAyNyArKysrLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0KPiAgMSBmaWxlIGNoYW5nZWQsIDQgaW5zZXJ0aW9ucygrKSwgMjMgZGVsZXRpb25zKC0p Cj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Jpb3MuYyBiL2Ry aXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Jpb3MuYwo+IGluZGV4IDNkY2Q1OWU2OTRkYi4uMTk4 ZmMzYzMyOTFiIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Jpb3Mu Ywo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Jpb3MuYwo+IEBAIC0xMDc1LDM0 ICsxMDc1LDE1IEBAIHBhcnNlX2RldmljZV9tYXBwaW5nKHN0cnVjdCBkcm1faTkxNV9wcml2YXRl ICpkZXZfcHJpdiwKPiAgCWNvbnN0IHVuaW9uIGNoaWxkX2RldmljZV9jb25maWcgKnBfY2hpbGQ7 Cj4gIAl1bmlvbiBjaGlsZF9kZXZpY2VfY29uZmlnICpjaGlsZF9kZXZfcHRyOwo+ICAJaW50IGks IGNoaWxkX2RldmljZV9udW0sIGNvdW50Owo+IC0JdTggZXhwZWN0ZWRfc2l6ZTsKPiAtCXUxNiBi bG9ja19zaXplOwo+ICsJdTE2CWJsb2NrX3NpemU7Cj4gIAo+ICAJcF9kZWZzID0gZmluZF9zZWN0 aW9uKGJkYiwgQkRCX0dFTkVSQUxfREVGSU5JVElPTlMpOwo+ICAJaWYgKCFwX2RlZnMpIHsKPiAg CQlEUk1fREVCVUdfS01TKCJObyBnZW5lcmFsIGRlZmluaXRpb24gYmxvY2sgaXMgZm91bmQsIG5v IGRldmljZXMgZGVmaW5lZC5cbiIpOwo+ICAJCXJldHVybjsKPiAgCX0KPiAtCWlmIChiZGItPnZl cnNpb24gPCAxOTUpIHsKPiAtCQlleHBlY3RlZF9zaXplID0gMzM7Cj4gLQl9IGVsc2UgaWYgKGJk Yi0+dmVyc2lvbiA9PSAxOTUpIHsKPiAtCQlleHBlY3RlZF9zaXplID0gMzc7Cj4gLQl9IGVsc2Ug aWYgKGJkYi0+dmVyc2lvbiA8PSAxOTcpIHsKPiAtCQlleHBlY3RlZF9zaXplID0gMzg7Cj4gLQl9 IGVsc2Ugewo+IC0JCWV4cGVjdGVkX3NpemUgPSAzODsKPiAtCQlEUk1fREVCVUdfRFJJVkVSKCJF eHBlY3RlZCBjaGlsZF9kZXZpY2VfY29uZmlnIHNpemUgZm9yIEJEQiB2ZXJzaW9uICV1IG5vdCBr bm93bjsgYXNzdW1pbmcgJXVcbiIsCj4gLQkJCQkgZXhwZWN0ZWRfc2l6ZSwgYmRiLT52ZXJzaW9u KTsKPiAtCX0KPiAtCj4gLQlpZiAoZXhwZWN0ZWRfc2l6ZSA+IHNpemVvZigqcF9jaGlsZCkpIHsK PiAtCQlEUk1fRVJST1IoImNoaWxkX2RldmljZV9jb25maWcgY2Fubm90IGZpdCBpbiBwX2NoaWxk XG4iKTsKPiAtCQlyZXR1cm47Cj4gLQl9Cj4gLQo+IC0JaWYgKHBfZGVmcy0+Y2hpbGRfZGV2X3Np emUgIT0gZXhwZWN0ZWRfc2l6ZSkgewo+IC0JCURSTV9FUlJPUigiU2l6ZSBtaXNtYXRjaDsgY2hp bGRfZGV2aWNlX2NvbmZpZyBzaXplPSV1IChleHBlY3RlZCAldSk7IGJkYi0+dmVyc2lvbjogJXVc biIsCj4gLQkJCSAgcF9kZWZzLT5jaGlsZF9kZXZfc2l6ZSwgZXhwZWN0ZWRfc2l6ZSwgYmRiLT52 ZXJzaW9uKTsKPiArCWlmIChwX2RlZnMtPmNoaWxkX2Rldl9zaXplIDwgc2l6ZW9mKCpwX2NoaWxk KSkgewo+ICsJCURSTV9FUlJPUigiR2VuZXJhbCBkZWZpbml0b24gYmxvY2sgY2hpbGQgZGV2aWNl IHNpemUgaXMgdG9vIHNtYWxsLlxuIik7Cj4gIAkJcmV0dXJuOwo+ICAJfQo+ICAJLyogZ2V0IHRo ZSBibG9jayBzaXplIG9mIGdlbmVyYWwgZGVmaW5pdGlvbnMgKi8KPiBAQCAtMTE0OSw3ICsxMTMw LDcgQEAgcGFyc2VfZGV2aWNlX21hcHBpbmcoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9w cml2LAo+ICAKPiAgCQljaGlsZF9kZXZfcHRyID0gZGV2X3ByaXYtPnZidC5jaGlsZF9kZXYgKyBj b3VudDsKPiAgCQljb3VudCsrOwo+IC0JCW1lbWNweShjaGlsZF9kZXZfcHRyLCBwX2NoaWxkLCBw X2RlZnMtPmNoaWxkX2Rldl9zaXplKTsKPiArCQltZW1jcHkoY2hpbGRfZGV2X3B0ciwgcF9jaGls ZCwgc2l6ZW9mKCpwX2NoaWxkKSk7Cj4gIAl9Cj4gIAlyZXR1cm47Cj4gIH0KPiAtLSAKPiAyLjEu NAoKLS0gClZpbGxlIFN5cmrDpGzDpApJbnRlbCBPVEMKX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhA bGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1h bi9saXN0aW5mby9pbnRlbC1nZngK