All of lore.kernel.org
 help / color / mirror / Atom feed
From: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
To: Axel Lin <axel.lin@ingics.com>
Cc: alsa-devel@alsa-project.org, Mark Brown <broonie@kernel.org>,
	Liam Girdwood <lgirdwood@gmail.com>,
	patches@opensource.wolfsonmicro.com
Subject: Re: [PATCH] ASoC: wm8741: Drop misleading readable_reg callback implementation
Date: Tue, 18 Aug 2015 14:09:29 +0100	[thread overview]
Message-ID: <20150818130929.GC9493@ck-lbox> (raw)
In-Reply-To: <1439546281.5150.2.camel@ingics.com>

On Fri, Aug 14, 2015 at 05:58:01PM +0800, Axel Lin wrote:
> regmap_readable() returns false if map->format.format_write is set.
> For .reg_bits = 7, .val_bits = 9, setting,
>   map->format.format_write = regmap_format_7_9_write;
> 
> Even current code has implemented map->readable_reg, regmap_readable()
> still returns false anyway. Thus drop the misleading readable_reg callback
> implementation.
> 
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
> ---

Acked-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>

Apologies, on the slight delay we have had a bit of an email
fiasco going on at this end, hopefully all resolved now.

Thanks,
Charles

  reply	other threads:[~2015-08-18 13:29 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-14  9:58 [PATCH] ASoC: wm8741: Drop misleading readable_reg callback implementation Axel Lin
2015-08-18 13:09 ` Charles Keepax [this message]
2015-08-18 16:33 ` Applied "ASoC: wm8741: Drop misleading readable_reg callback implementation" to the asoc tree Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150818130929.GC9493@ck-lbox \
    --to=ckeepax@opensource.wolfsonmicro.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=axel.lin@ingics.com \
    --cc=broonie@kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=patches@opensource.wolfsonmicro.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.