From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Lunn Subject: Re: [PATCH net-next v3] rocker: add debugfs support to dump internal tables Date: Tue, 18 Aug 2015 16:01:56 +0200 Message-ID: <20150818140156.GE4381@lunn.ch> References: <1439850977-31079-1-git-send-email-sfeldma@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: netdev@vger.kernel.org, jiri@resnulli.us To: sfeldma@gmail.com Return-path: Received: from vps0.lunn.ch ([178.209.37.122]:33010 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751594AbbHROJN (ORCPT ); Tue, 18 Aug 2015 10:09:13 -0400 Content-Disposition: inline In-Reply-To: <1439850977-31079-1-git-send-email-sfeldma@gmail.com> Sender: netdev-owner@vger.kernel.org List-ID: On Mon, Aug 17, 2015 at 03:36:17PM -0700, sfeldma@gmail.com wrote: > From: Scott Feldman > > > tree /sys/kernel/debug/rocker > /sys/kernel/debug/rocker > ????????? 5254001235010000 > ????????? fdb_tbl > ????????? internal_vlan_tbl > ????????? neigh_tbl > ????????? of_dpa_flow_tbl > ????????? of_dpa_group_tbl > > 1 directory, 5 files > > > cat /sys/kernel/debug/rocker/5254001235010000/internal_vlan_tbl > ifindex 5 ref_count 1 vlan 3843 > ifindex 7 ref_count 2 vlan 3840 > ifindex 4 ref_count 1 vlan 3842 > > > cat /sys/kernel/debug/rocker/5254001235010000/fdb_tbl > learned 1 pport 1 addr 00:02:00:00:02:00 vlan 3840 > learned 1 pport 2 addr 00:02:00:00:03:00 vlan 3840 > > > cat /sys/kernel/debug/rocker/5254001235010000/neigh_tbl > 11.0.0.9 dev sw1p2 ref_count 3 index 1 dst 00:02:00:00:01:00 ttl_check 1 > 11.0.0.1 dev sw1p1 ref_count 3 index 0 dst 00:02:00:00:00:00 ttl_check 1 Hi Scott David is not so keen no debugfs stuff. He already NACKed adding more than what is currently in DSA: https://lkml.org/lkml/2015/7/11/8 I think the key thing from David's message is: > Fetching information should be done by well typed, generic, > interfaces that apply to any similar device or object. So rather than splattering rocker stuff in debugfs, we should really be thinking about an interface which works well for both Rocker and DSA, i.e. generic, and keeps David happy by being typed. No idea what that actually is, not thought about it yet. Andrew