From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH for v4.2] Revert "drm/i915: Allow parsing of variable size child device entries from VBT" Date: Tue, 18 Aug 2015 20:00:40 +0300 Message-ID: <20150818170040.GL5176@intel.com> References: <1439890416-16826-1-git-send-email-jani.nikula@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTP id 100FD6E291 for ; Tue, 18 Aug 2015 10:01:09 -0700 (PDT) Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Daniel Vetter Cc: Jani Nikula , intel-gfx List-Id: intel-gfx@lists.freedesktop.org T24gVHVlLCBBdWcgMTgsIDIwMTUgYXQgMDk6NTg6NTdBTSAtMDcwMCwgRGFuaWVsIFZldHRlciB3 cm90ZToKPiBPbiBUdWUsIEF1ZyAxOCwgMjAxNSBhdCAyOjMzIEFNLCBKYW5pIE5pa3VsYSA8amFu aS5uaWt1bGFAaW50ZWwuY29tPiB3cm90ZToKPiA+IFRoaXMgcmV2ZXJ0cwo+ID4KPiA+IGNvbW1p dCAwNDdmZTZlNmRiOTE2MWU2OTI3MWY1NmRhYWFmZGFmMmFkZDAyM2IxCj4gPiBBdXRob3I6IERh dmlkIFdlaW5laGFsbCA8ZGF2aWQud2VpbmVoYWxsQGxpbnV4LmludGVsLmNvbT4KPiA+IERhdGU6 ICAgVHVlIEF1ZyA0IDE2OjU1OjUyIDIwMTUgKzAzMDAKPiA+Cj4gPiAgICAgZHJtL2k5MTU6IEFs bG93IHBhcnNpbmcgb2YgdmFyaWFibGUgc2l6ZSBjaGlsZCBkZXZpY2UgZW50cmllcyBmcm9tIFZC VAo+ID4KPiA+IFRoYXQgY29tbWl0IGlzIG5vdCB2YWxpZCBmb3IgdjQuMiwgaG93ZXZlciBpdCB3 aWxsIGJlIHZhbGlkIGZvciB2NC4zLiBJdAo+ID4gd2FzIHNpbXBseSBxdWV1ZWQgdG9vIGVhcmx5 Lgo+IAo+IE5vcGUsIHRoaXMgcGF0Y2ggZnJvbSBEYXZpZCBhbHNvIGluY2lkZW50YWxseSBmaXhl cyBhIHJlZ3Jlc3Npb24gZnJvbQo+IDkwZTRmMTU5MmJiNmU4MmY2NjkwZjBlMDVhOGFhZGMgd2hp Y2ggaXMgd2h5IEkgbWVyZ2VkIGl0IHRvLgoKV2hhdCByZWdyZXNzaW9uPwoKPiBJZiB5b3UKPiB3 YW50IHRvIHJldmVydCB0aGlzLCB5b3UgbmVlZCB0byByZXZlcnQgbW9yZSAoYW5kIHdpdGggdGhh dCBhbHNvIGJyZWFrCj4gQlNXKS4KPiAKPiBJc24ndCB0aGVyZSBhIG1vcmUgbWluaW1hbCBmaXgg d2UgY2FuIGRvIGZvciA0LjI/Cj4gLURhbmllbAo+IAo+ID4KPiA+IFRoZSByZWZlcmVuY2VkIHJl Z3Jlc3NpbmcgY29tbWl0IGlzIGp1c3QgZmluZSB1bnRpbCB0aGUgc2l6ZSBvZiBzdHJ1Y3QKPiA+ IGNvbW1vbl9jaGlsZF9kZXZfY29uZmlnIGNoYW5nZXMsIGFuZCB0aGF0IHdvbid0IGhhcHBlbiB1 bnRpbAo+ID4gdjQuMy4gSW5kZWVkLCB0aGUgZXhwZWN0ZWQgc2l6ZSBjaGVja3MgaGVyZSByZWx5 IG9uIHRoZSBpbmNyZWFzZWQgc2l6ZQo+ID4gb2YgdGhlIHN0cnVjdCwgYnJlYWtpbmcgbmV3IHBs YXRmb3Jtcy4KPiA+Cj4gPiBGaXhlczogMDQ3ZmU2ZTZkYjkxICgiZHJtL2k5MTU6IEFsbG93IHBh cnNpbmcgb2YgdmFyaWFibGUgc2l6ZSBjaGlsZCBkZXZpY2UgZW50cmllcyBmcm9tIFZCVCIpCj4g PiBDYzogRGFuaWVsIFZldHRlciA8ZGFuaWVsQGZmd2xsLmNoPgo+ID4gQ2M6IERhdmlkIFdlaW5l aGFsbCA8ZGF2aWQud2VpbmVoYWxsQGxpbnV4LmludGVsLmNvbT4KPiA+IENjOiBWaWxsZSBTeXJq w6Rsw6QgPHZpbGxlLnN5cmphbGFAbGludXguaW50ZWwuY29tPgo+ID4gU2lnbmVkLW9mZi1ieTog SmFuaSBOaWt1bGEgPGphbmkubmlrdWxhQGludGVsLmNvbT4KPiA+Cj4gPiAtLS0KPiA+Cj4gPiBU aGVyZSB3YXMgYW5vdGhlciBwYXRjaCBmcm9tIERhdmlkIGluY3JlYXNpbmcgdGhlIHNpemUgb2Yg dGhlIHN0cnVjdAo+ID4gWzFdLCBidXQgdGhhdCB0aGVuIHJlZ3Jlc3NlcyBzZHZvIG1hcHBpbmcg cGFyc2luZy4gSXQncyB0aGUgc2ltcGxlc3QgdG8KPiA+IGp1c3QgcmV2ZXJ0IGFuZCBmaXggdGhp cyB1cCBwcm9wZXJseSBmb3IgdjQuMy4KPiA+Cj4gPiBbMV0gaHR0cDovL21pZC5nbWFuZS5vcmcv MjAxNTA4MTMxMzE0MTUuR082MTUwQGJvb20KPiA+IC0tLQo+ID4gIGRyaXZlcnMvZ3B1L2RybS9p OTE1L2ludGVsX2Jpb3MuYyB8IDI3ICsrKystLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQo+ID4gIDEg ZmlsZSBjaGFuZ2VkLCA0IGluc2VydGlvbnMoKyksIDIzIGRlbGV0aW9ucygtKQo+ID4KPiA+IGRp ZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9iaW9zLmMgYi9kcml2ZXJzL2dw dS9kcm0vaTkxNS9pbnRlbF9iaW9zLmMKPiA+IGluZGV4IDNkY2Q1OWU2OTRkYi4uMTk4ZmMzYzMy OTFiIDEwMDY0NAo+ID4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfYmlvcy5jCj4g PiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9iaW9zLmMKPiA+IEBAIC0xMDc1LDM0 ICsxMDc1LDE1IEBAIHBhcnNlX2RldmljZV9tYXBwaW5nKHN0cnVjdCBkcm1faTkxNV9wcml2YXRl ICpkZXZfcHJpdiwKPiA+ICAgICAgICAgY29uc3QgdW5pb24gY2hpbGRfZGV2aWNlX2NvbmZpZyAq cF9jaGlsZDsKPiA+ICAgICAgICAgdW5pb24gY2hpbGRfZGV2aWNlX2NvbmZpZyAqY2hpbGRfZGV2 X3B0cjsKPiA+ICAgICAgICAgaW50IGksIGNoaWxkX2RldmljZV9udW0sIGNvdW50Owo+ID4gLSAg ICAgICB1OCBleHBlY3RlZF9zaXplOwo+ID4gLSAgICAgICB1MTYgYmxvY2tfc2l6ZTsKPiA+ICsg ICAgICAgdTE2ICAgICBibG9ja19zaXplOwo+ID4KPiA+ICAgICAgICAgcF9kZWZzID0gZmluZF9z ZWN0aW9uKGJkYiwgQkRCX0dFTkVSQUxfREVGSU5JVElPTlMpOwo+ID4gICAgICAgICBpZiAoIXBf ZGVmcykgewo+ID4gICAgICAgICAgICAgICAgIERSTV9ERUJVR19LTVMoIk5vIGdlbmVyYWwgZGVm aW5pdGlvbiBibG9jayBpcyBmb3VuZCwgbm8gZGV2aWNlcyBkZWZpbmVkLlxuIik7Cj4gPiAgICAg ICAgICAgICAgICAgcmV0dXJuOwo+ID4gICAgICAgICB9Cj4gPiAtICAgICAgIGlmIChiZGItPnZl cnNpb24gPCAxOTUpIHsKPiA+IC0gICAgICAgICAgICAgICBleHBlY3RlZF9zaXplID0gMzM7Cj4g PiAtICAgICAgIH0gZWxzZSBpZiAoYmRiLT52ZXJzaW9uID09IDE5NSkgewo+ID4gLSAgICAgICAg ICAgICAgIGV4cGVjdGVkX3NpemUgPSAzNzsKPiA+IC0gICAgICAgfSBlbHNlIGlmIChiZGItPnZl cnNpb24gPD0gMTk3KSB7Cj4gPiAtICAgICAgICAgICAgICAgZXhwZWN0ZWRfc2l6ZSA9IDM4Owo+ ID4gLSAgICAgICB9IGVsc2Ugewo+ID4gLSAgICAgICAgICAgICAgIGV4cGVjdGVkX3NpemUgPSAz ODsKPiA+IC0gICAgICAgICAgICAgICBEUk1fREVCVUdfRFJJVkVSKCJFeHBlY3RlZCBjaGlsZF9k ZXZpY2VfY29uZmlnIHNpemUgZm9yIEJEQiB2ZXJzaW9uICV1IG5vdCBrbm93bjsgYXNzdW1pbmcg JXVcbiIsCj4gPiAtICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBleHBlY3RlZF9zaXpl LCBiZGItPnZlcnNpb24pOwo+ID4gLSAgICAgICB9Cj4gPiAtCj4gPiAtICAgICAgIGlmIChleHBl Y3RlZF9zaXplID4gc2l6ZW9mKCpwX2NoaWxkKSkgewo+ID4gLSAgICAgICAgICAgICAgIERSTV9F UlJPUigiY2hpbGRfZGV2aWNlX2NvbmZpZyBjYW5ub3QgZml0IGluIHBfY2hpbGRcbiIpOwo+ID4g LSAgICAgICAgICAgICAgIHJldHVybjsKPiA+IC0gICAgICAgfQo+ID4gLQo+ID4gLSAgICAgICBp ZiAocF9kZWZzLT5jaGlsZF9kZXZfc2l6ZSAhPSBleHBlY3RlZF9zaXplKSB7Cj4gPiAtICAgICAg ICAgICAgICAgRFJNX0VSUk9SKCJTaXplIG1pc21hdGNoOyBjaGlsZF9kZXZpY2VfY29uZmlnIHNp emU9JXUgKGV4cGVjdGVkICV1KTsgYmRiLT52ZXJzaW9uOiAldVxuIiwKPiA+IC0gICAgICAgICAg ICAgICAgICAgICAgICAgcF9kZWZzLT5jaGlsZF9kZXZfc2l6ZSwgZXhwZWN0ZWRfc2l6ZSwgYmRi LT52ZXJzaW9uKTsKPiA+ICsgICAgICAgaWYgKHBfZGVmcy0+Y2hpbGRfZGV2X3NpemUgPCBzaXpl b2YoKnBfY2hpbGQpKSB7Cj4gPiArICAgICAgICAgICAgICAgRFJNX0VSUk9SKCJHZW5lcmFsIGRl ZmluaXRvbiBibG9jayBjaGlsZCBkZXZpY2Ugc2l6ZSBpcyB0b28gc21hbGwuXG4iKTsKPiA+ICAg ICAgICAgICAgICAgICByZXR1cm47Cj4gPiAgICAgICAgIH0KPiA+ICAgICAgICAgLyogZ2V0IHRo ZSBibG9jayBzaXplIG9mIGdlbmVyYWwgZGVmaW5pdGlvbnMgKi8KPiA+IEBAIC0xMTQ5LDcgKzEx MzAsNyBAQCBwYXJzZV9kZXZpY2VfbWFwcGluZyhzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2 X3ByaXYsCj4gPgo+ID4gICAgICAgICAgICAgICAgIGNoaWxkX2Rldl9wdHIgPSBkZXZfcHJpdi0+ dmJ0LmNoaWxkX2RldiArIGNvdW50Owo+ID4gICAgICAgICAgICAgICAgIGNvdW50Kys7Cj4gPiAt ICAgICAgICAgICAgICAgbWVtY3B5KGNoaWxkX2Rldl9wdHIsIHBfY2hpbGQsIHBfZGVmcy0+Y2hp bGRfZGV2X3NpemUpOwo+ID4gKyAgICAgICAgICAgICAgIG1lbWNweShjaGlsZF9kZXZfcHRyLCBw X2NoaWxkLCBzaXplb2YoKnBfY2hpbGQpKTsKPiA+ICAgICAgICAgfQo+ID4gICAgICAgICByZXR1 cm47Cj4gPiAgfQo+ID4gLS0KPiA+IDIuMS40Cj4gPgo+IAo+IAo+IAo+IC0tIAo+IERhbmllbCBW ZXR0ZXIKPiBTb2Z0d2FyZSBFbmdpbmVlciwgSW50ZWwgQ29ycG9yYXRpb24KPiArNDEgKDApIDc5 IDM2NSA1NyA0OCAtIGh0dHA6Ly9ibG9nLmZmd2xsLmNoCgotLSAKVmlsbGUgU3lyasOkbMOkCklu dGVsIE9UQwpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJ bnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0 cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=