From mboxrd@z Thu Jan 1 00:00:00 1970 From: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= Subject: Re: [PATCH V3] Watchdog: Fix parent of watchdog_devices Date: Wed, 19 Aug 2015 08:44:19 +0200 Message-ID: <20150819064419.GC9999@pengutronix.de> References: Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from metis.ext.pengutronix.de ([92.198.50.35]:58234 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752687AbbHSGoo (ORCPT ); Wed, 19 Aug 2015 02:44:44 -0400 Content-Disposition: inline In-Reply-To: Sender: linux-samsung-soc-owner@vger.kernel.org List-Id: linux-samsung-soc@vger.kernel.org To: Pratyush Anand Cc: linux@roeck-us.net, Krzysztof Kozlowski , "open list:WOLFSON MICROELECTRONICS DRIVERS" , "open list:ARM/STI ARCHITECTURE" , Linus Walleij , Baruch Siach , "open list:INTEL MANAGEMENT ENGINE mei" , Wim Van Sebroeck , Thierry Reding , Alexandre Courbot , "moderated list:ARM/SAMSUNG EXYNOS ARM ARCHITECTURES" , Lee Jones , Kukjin Kim , Tomas Winkler , linux-watchdog@vger.kernel.org, Stephen Warren , "moderated list:BROADCOM BCM2835 ARM ARCHITECTURE" , "open list:TEGRA ARCHITECTURE SUPPORT" Hello, On Wed, Aug 19, 2015 at 08:58:24AM +0530, Pratyush Anand wrote: > /sys/class/watchdog/watchdogn/device/modalias can help to identify th= e > driver/module for a given watchdog node. However, many wdt devices do= es not set s/es// > its parent and so, we do not see an entry for device in sysfs for suc= h devices. >=20 > This patch fixes parent of watchdog_device so that > /sys/class/watchdog/watchdogn/device is populated. >=20 > Exceptions: booke, diag288, mpc8xxx, octeon, softdog and w83627hf -- = They do not > have any parent. Not sure, how we can we identify driver for these de= vices. I don't see why you don't use the platform device as parent for mpc8xxx= =2E Note however that I did several updates to the mpc8xxx driver which probably conflict with setting the parent. I'll take care of that. Best regards Uwe --=20 Pengutronix e.K. | Uwe Kleine-K=F6nig = | Industrial Linux Solutions | http://www.pengutronix.de/= | From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from metis.ext.pengutronix.de ([92.198.50.35]:42285 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752688AbbHSGoo (ORCPT ); Wed, 19 Aug 2015 02:44:44 -0400 Date: Wed, 19 Aug 2015 08:44:19 +0200 From: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= To: Pratyush Anand Cc: linux@roeck-us.net, Krzysztof Kozlowski , "open list:WOLFSON MICROELECTRONICS DRIVERS" , "open list:ARM/STI ARCHITECTURE" , Linus Walleij , Baruch Siach , "open list:INTEL MANAGEMENT ENGINE mei" , Wim Van Sebroeck , Thierry Reding , Alexandre Courbot , "moderated list:ARM/SAMSUNG EXYNOS ARM ARCHITECTURES" , Lee Jones , Kukjin Kim , Tomas Winkler , linux-watchdog@vger.kernel.org, Stephen Warren , "moderated list:BROADCOM BCM2835 ARM ARCHITECTURE" , "open list:TEGRA ARCHITECTURE SUPPORT" , "moderated list:ARM/U300 MACHINE SUPPORT" , Maxime Coquelin , Barry Song , Johannes Thumshirn , Support Opensource , Andreas Werner , Srinivas Kandagatla , Patrice Chotard , kbuild test robot Subject: Re: [PATCH V3] Watchdog: Fix parent of watchdog_devices Message-ID: <20150819064419.GC9999@pengutronix.de> References: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: Sender: linux-watchdog-owner@vger.kernel.org List-Id: linux-watchdog@vger.kernel.org Content-Transfer-Encoding: quoted-printable Hello, On Wed, Aug 19, 2015 at 08:58:24AM +0530, Pratyush Anand wrote: > /sys/class/watchdog/watchdogn/device/modalias can help to identify the > driver/module for a given watchdog node. However, many wdt devices does= not set s/es// > its parent and so, we do not see an entry for device in sysfs for such = devices. >=20 > This patch fixes parent of watchdog_device so that > /sys/class/watchdog/watchdogn/device is populated. >=20 > Exceptions: booke, diag288, mpc8xxx, octeon, softdog and w83627hf -- Th= ey do not > have any parent. Not sure, how we can we identify driver for these devi= ces. I don't see why you don't use the platform device as parent for mpc8xxx. Note however that I did several updates to the mpc8xxx driver which probably conflict with setting the parent. I'll take care of that. Best regards Uwe --=20 Pengutronix e.K. | Uwe Kleine-K=F6nig = | Industrial Linux Solutions | http://www.pengutronix.de/ = | -- To unsubscribe from this list: send the line "unsubscribe linux-watchdog"= in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: u.kleine-koenig@pengutronix.de (Uwe =?iso-8859-1?Q?Kleine-K=F6nig?=) Date: Wed, 19 Aug 2015 08:44:19 +0200 Subject: [PATCH V3] Watchdog: Fix parent of watchdog_devices In-Reply-To: References: Message-ID: <20150819064419.GC9999@pengutronix.de> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hello, On Wed, Aug 19, 2015 at 08:58:24AM +0530, Pratyush Anand wrote: > /sys/class/watchdog/watchdogn/device/modalias can help to identify the > driver/module for a given watchdog node. However, many wdt devices does not set s/es// > its parent and so, we do not see an entry for device in sysfs for such devices. > > This patch fixes parent of watchdog_device so that > /sys/class/watchdog/watchdogn/device is populated. > > Exceptions: booke, diag288, mpc8xxx, octeon, softdog and w83627hf -- They do not > have any parent. Not sure, how we can we identify driver for these devices. I don't see why you don't use the platform device as parent for mpc8xxx. Note however that I did several updates to the mpc8xxx driver which probably conflict with setting the parent. I'll take care of that. Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-K?nig | Industrial Linux Solutions | http://www.pengutronix.de/ | From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752751AbbHSGoo (ORCPT ); Wed, 19 Aug 2015 02:44:44 -0400 Received: from metis.ext.pengutronix.de ([92.198.50.35]:55714 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752532AbbHSGon (ORCPT ); Wed, 19 Aug 2015 02:44:43 -0400 Date: Wed, 19 Aug 2015 08:44:19 +0200 From: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= To: Pratyush Anand Cc: linux@roeck-us.net, Krzysztof Kozlowski , "open list:WOLFSON MICROELECTRONICS DRIVERS" , "open list:ARM/STI ARCHITECTURE" , Linus Walleij , Baruch Siach , "open list:INTEL MANAGEMENT ENGINE mei" , Wim Van Sebroeck , Thierry Reding , Alexandre Courbot , "moderated list:ARM/SAMSUNG EXYNOS ARM ARCHITECTURES" , Lee Jones , Kukjin Kim , Tomas Winkler , linux-watchdog@vger.kernel.org, Stephen Warren , "moderated list:BROADCOM BCM2835 ARM ARCHITECTURE" , "open list:TEGRA ARCHITECTURE SUPPORT" , "moderated list:ARM/U300 MACHINE SUPPORT" , Maxime Coquelin , Barry Song , Johannes Thumshirn , Support Opensource , Andreas Werner , Srinivas Kandagatla , Patrice Chotard , kbuild test robot Subject: Re: [PATCH V3] Watchdog: Fix parent of watchdog_devices Message-ID: <20150819064419.GC9999@pengutronix.de> References: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, On Wed, Aug 19, 2015 at 08:58:24AM +0530, Pratyush Anand wrote: > /sys/class/watchdog/watchdogn/device/modalias can help to identify the > driver/module for a given watchdog node. However, many wdt devices does not set s/es// > its parent and so, we do not see an entry for device in sysfs for such devices. > > This patch fixes parent of watchdog_device so that > /sys/class/watchdog/watchdogn/device is populated. > > Exceptions: booke, diag288, mpc8xxx, octeon, softdog and w83627hf -- They do not > have any parent. Not sure, how we can we identify driver for these devices. I don't see why you don't use the platform device as parent for mpc8xxx. Note however that I did several updates to the mpc8xxx driver which probably conflict with setting the parent. I'll take care of that. Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | http://www.pengutronix.de/ |