All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: serjk@netup.ru
Cc: linux-media@vger.kernel.org
Subject: re: [media] netup_unidvb: NetUP Universal DVB-S/S2/T/T2/C PCI-E card driver
Date: Wed, 19 Aug 2015 11:01:32 +0300	[thread overview]
Message-ID: <20150819080132.GA30902@mwanda> (raw)

Hello Kozlov Sergey,

The patch 52b1eaf4c59a: "[media] netup_unidvb: NetUP Universal
DVB-S/S2/T/T2/C PCI-E card driver" from Jul 28, 2015, leads to the
following static checker warning:

	drivers/media/pci/netup_unidvb/netup_unidvb_spi.c:84 netup_spi_interrupt()
	error: we previously assumed 'spi' could be null (see line 83)

drivers/media/pci/netup_unidvb/netup_unidvb_spi.c
    78  irqreturn_t netup_spi_interrupt(struct netup_spi *spi)
    79  {
    80          u16 reg;
    81          unsigned long flags;
    82  
    83          if (!spi) {
                    ^^^^
    84                  dev_dbg(&spi->master->dev,
                                ^^^^^^^^^^^^^^^^^
    85                          "%s(): SPI not initialized\n", __func__);
    86                  return IRQ_NONE;
    87          }
    88          spin_lock_irqsave(&spi->lock, flags);


See also:

	drivers/media/pci/netup_unidvb/netup_unidvb_spi.c:238 netup_spi_release()
	error: we previously assumed 'spi' could be null (see line 237)

regards,
dan carpenter

                 reply	other threads:[~2015-08-19  8:01 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150819080132.GA30902@mwanda \
    --to=dan.carpenter@oracle.com \
    --cc=linux-media@vger.kernel.org \
    --cc=serjk@netup.ru \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.