From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Daniel Borkmann <daniel@iogearbox.net>
Cc: tgraf@suug.ch, challa@noironetworks.com, netfilter-devel@vger.kernel.org
Subject: Re: [PATCH iptables] libxt_CT: add support for recently introduced zone options
Date: Thu, 20 Aug 2015 00:05:50 +0200 [thread overview]
Message-ID: <20150819220550.GA5313@salvia> (raw)
In-Reply-To: <55be6cc4f6e6d0f7c590b6fefc678c36711ac05d.1439062590.git.daniel@iogearbox.net>
On Sat, Aug 08, 2015 at 09:45:04PM +0200, Daniel Borkmann wrote:
[...]
> diff --git a/extensions/libxt_CT.c b/extensions/libxt_CT.c
> index 6b28fe1..86b1221 100644
> --- a/extensions/libxt_CT.c
> +++ b/extensions/libxt_CT.c
> @@ -16,7 +16,8 @@ static void ct_help(void)
> " --helper name Use conntrack helper 'name' for connection\n"
> " --ctevents event[,event...] Generate specified conntrack events for connection\n"
> " --expevents event[,event...] Generate specified expectation events for connection\n"
> -" --zone ID Assign/Lookup connection in zone ID\n"
> +" --zone {ID|mark} Assign/Lookup connection in zone ID/packet nfmark\n"
> +" --zone-dir {ORIGINAL|REPLY} Only apply zone in a particular direction\n"
I suggest you add these options:
--zone-orig ...
--zone-reply ...
--zone ...
so they match to what we have in the ctnetlink interface. Thanks!
next prev parent reply other threads:[~2015-08-19 21:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-08 19:45 [PATCH iptables] libxt_CT: add support for recently introduced zone options Daniel Borkmann
2015-08-19 22:05 ` Pablo Neira Ayuso [this message]
-- strict thread matches above, loose matches on Subject: below --
2015-07-22 10:59 Daniel Borkmann
2015-07-11 1:18 Daniel Borkmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150819220550.GA5313@salvia \
--to=pablo@netfilter.org \
--cc=challa@noironetworks.com \
--cc=daniel@iogearbox.net \
--cc=netfilter-devel@vger.kernel.org \
--cc=tgraf@suug.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.