From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [v3 1/4] spi: cadence_qspi: move trigger base configuration in init
Date: Thu, 20 Aug 2015 05:46:13 +0200 [thread overview]
Message-ID: <201508200546.13318.marex@denx.de> (raw)
In-Reply-To: <1439604960-23919-2-git-send-email-vikas.manocha@st.com>
On Saturday, August 15, 2015 at 04:15:57 AM, Vikas Manocha wrote:
> No need to configure indirect trigger address for every read/write.
>
> Signed-off-by: Vikas Manocha <vikas.manocha@st.com>
> ---
>
> Changes in v3: added commit message & removed extra bracket.
> Changes in v2: Rebased to master
>
> drivers/spi/cadence_qspi_apb.c | 9 ++-------
> 1 file changed, 2 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/spi/cadence_qspi_apb.c
> b/drivers/spi/cadence_qspi_apb.c index d053407..b46e5fe 100644
> --- a/drivers/spi/cadence_qspi_apb.c
> +++ b/drivers/spi/cadence_qspi_apb.c
> @@ -534,6 +534,8 @@ void cadence_qspi_apb_controller_init(struct
> cadence_spi_platdata *plat)
>
> /* Indirect mode configurations */
> writel((plat->sram_size/2), plat->regbase + CQSPI_REG_SRAMPARTITION);
> + writel((u32)plat->ahbbase & CQSPI_INDIRECTTRIGGER_ADDR_MASK,
> + plat->regbase + CQSPI_REG_INDIRECTTRIGGER);
Please drop this (u32) cast, it's misleading and problematic.
Best regards,
Marek Vasut
next prev parent reply other threads:[~2015-08-20 3:46 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-15 2:15 [U-Boot] [v3 0/4] spi: cadence_qspi: optimize & fix indirect rd-writes Vikas Manocha
2015-08-15 2:15 ` [U-Boot] [v3 1/4] spi: cadence_qspi: move trigger base configuration in init Vikas Manocha
2015-08-20 3:46 ` Marek Vasut [this message]
2015-08-20 16:27 ` vikas
2015-08-15 2:15 ` [U-Boot] [v3 2/4] spi: cadence_qspi: fix indirect read/write start address Vikas Manocha
2015-08-20 3:46 ` Marek Vasut
2015-08-20 16:28 ` vikas
2015-08-15 2:15 ` [U-Boot] [v3 3/4] spi: cadence_qspi: fix base trigger address & transfer " Vikas Manocha
2015-08-20 3:54 ` Marek Vasut
2015-08-20 16:48 ` vikas
2015-08-20 21:56 ` Marek Vasut
2015-08-20 22:25 ` vikas
2015-08-20 23:05 ` Marek Vasut
2015-08-15 2:16 ` [U-Boot] [v3 4/4] spi: cadence_qspi: get fifo width from device tree Vikas Manocha
2015-08-20 3:54 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201508200546.13318.marex@denx.de \
--to=marex@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.