Re: [PATCH] build: use _DEFAULT_SOURCE for newer glibc

[Mike Frysinger <vapier@gentoo.org>]

[-- Attachment #1: Type: text/plain, Size: 1022 bytes --]

On 20 Aug 2015 10:12, Jan Engelhardt wrote:
> On Wednesday 2015-08-19 15:08, Mike Frysinger wrote:
> >On 19 Aug 2015 09:09, Jan Engelhardt wrote:
> >> On Wednesday 2015-08-19 00:07, Mike Frysinger wrote:
> >> >Since _BSD_SOURCE is deprecated with newer glibc versions, we get build
> >> >warnings when using only that define.  Add the newer _DEFAULT_SOURCE to
> >> >quiet things down.
> >> 
> >> Why do we even need _BSD_SOURCE/_ISOC99_SOURCE/_DEFAULT_SOURCE? The 
> >> thing apparently builds without it (glibc-2.19), too.
> >
> >i would check with the guy who committed this ;)
> >
> >    build: resolve compile abort in libxt_limit on RHEL5
> >    
> >    libxt_limit.c: In function 'print_rate':
> >        libxt_limit.c:124: error: 'INFINITY' undeclared (first use in
> >        this function)
> 
> Well if that is the case, have you checked that using _DEFAULT_SOURCE
> over _ISOC99_SOURCE+_BSD_SOURCE still works on RHEL5?

i know it won't because _DEFAULT_SOURCE is new to glibc-2.19
-mike

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]