From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maxime Ripard Subject: Re: [PATCH 3/9] spi: sunxi: check that transfer speed is non-zero Date: Thu, 20 Aug 2015 16:48:36 +0200 Message-ID: <20150820144836.GV30520@lukather> References: <3688fab67e7cdc7bcbff73dfd6b0fcdcc4e79eb6.1440080122.git.hramrach@gmail.com> Reply-To: maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="YnIutncTLXsDZs5t" Cc: linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org, Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Russell King , Mark Brown , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Michal Suchanek Return-path: Content-Disposition: inline In-Reply-To: <3688fab67e7cdc7bcbff73dfd6b0fcdcc4e79eb6.1440080122.git.hramrach-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , List-Id: linux-spi.vger.kernel.org --YnIutncTLXsDZs5t Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline On Thu, Aug 20, 2015 at 02:19:46PM -0000, Michal Suchanek wrote: > When the maximum transfer speed is not set for a SPI slave the value > remains 0 and the code in sunxi SPI divides by it. Use an arbitrary > speed instead in that case. > > Signed-off-by: Michal Suchanek spi->max_speed_hz is set using the spi-max-frequency property, and spi->will error out if that property isn't set. What am I missing? Maxime -- Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com --YnIutncTLXsDZs5t-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: maxime.ripard@free-electrons.com (Maxime Ripard) Date: Thu, 20 Aug 2015 16:48:36 +0200 Subject: [PATCH 3/9] spi: sunxi: check that transfer speed is non-zero In-Reply-To: <3688fab67e7cdc7bcbff73dfd6b0fcdcc4e79eb6.1440080122.git.hramrach@gmail.com> References: <3688fab67e7cdc7bcbff73dfd6b0fcdcc4e79eb6.1440080122.git.hramrach@gmail.com> Message-ID: <20150820144836.GV30520@lukather> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Thu, Aug 20, 2015 at 02:19:46PM -0000, Michal Suchanek wrote: > When the maximum transfer speed is not set for a SPI slave the value > remains 0 and the code in sunxi SPI divides by it. Use an arbitrary > speed instead in that case. > > Signed-off-by: Michal Suchanek spi->max_speed_hz is set using the spi-max-frequency property, and spi->will error out if that property isn't set. What am I missing? Maxime -- Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: Digital signature URL: From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932120AbbHTOsn (ORCPT ); Thu, 20 Aug 2015 10:48:43 -0400 Received: from down.free-electrons.com ([37.187.137.238]:41629 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753091AbbHTOsi (ORCPT ); Thu, 20 Aug 2015 10:48:38 -0400 Date: Thu, 20 Aug 2015 16:48:36 +0200 From: Maxime Ripard To: Michal Suchanek Cc: linux-sunxi@googlegroups.com, Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Russell King , Mark Brown , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org Subject: Re: [PATCH 3/9] spi: sunxi: check that transfer speed is non-zero Message-ID: <20150820144836.GV30520@lukather> References: <3688fab67e7cdc7bcbff73dfd6b0fcdcc4e79eb6.1440080122.git.hramrach@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="YnIutncTLXsDZs5t" Content-Disposition: inline In-Reply-To: <3688fab67e7cdc7bcbff73dfd6b0fcdcc4e79eb6.1440080122.git.hramrach@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --YnIutncTLXsDZs5t Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Aug 20, 2015 at 02:19:46PM -0000, Michal Suchanek wrote: > When the maximum transfer speed is not set for a SPI slave the value > remains 0 and the code in sunxi SPI divides by it. Use an arbitrary > speed instead in that case. >=20 > Signed-off-by: Michal Suchanek spi->max_speed_hz is set using the spi-max-frequency property, and spi->will error out if that property isn't set. What am I missing? Maxime --=20 Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com --YnIutncTLXsDZs5t Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJV1ejEAAoJEBx+YmzsjxAgrzoP/3TEQFw0jjKi4me7tQ7h+eRd pHazq0mAnd8FdZM+0pCNIAXfJ40IUUpR1KkAJE+CbyafGF+AxY1DivH3EY+X+dBs 4rPDxA7ooOUUnyinJLcjXY79oM9AEQmxiJ6P8kRR9UL3T0Xz8p+2LpQMvUqqumPq V9PdeVsUJ3qpbL3uPdHiCs7uvlhnLYWcaDkkcFpSLguDKtGbGPNwUVm+h4IrIRHk 07D6f2894VZmvum7HfVnP8wqPv4Y0uHpgkUk+LONKU3pmrc5A4r3FL7Vl+kdV6oi UpH5vzn5lTffL0dshFKdymubUfeZ1RqumgICpWhLmuGhwrmuCsrB4oipozDREr/H wSUp6tpJZMrLGiWbQnprxlw3Eu9IxbkPoxnl3dzTt2L1qDQwwDbKKVZ1lyDolwRV uNFlE7XSZkL7i19CeMClzWFSoW4HKRsKeVPUwuQJuwSTw5R45PwwJ07zNNOBZ1x3 Wx8GNFy8msdzG5RlNC89mFIq1IEHf21B8xP36uTMDbA7HZbmzzA8xDFrtsrNYHFq 0qUwKY6WHRZEugEFpF2elyJN1r1t9FEM9EHjveO+kBrSoV3AmXOqL+XsihY7j+7q nYpkngrNfEl5FOsa173wYGArT9HkVYQKBeH3aRuyHKUe/dBqabE9Wgk/dTYIeI/W X91/9EgSTH6zriwhwWGd =xj4q -----END PGP SIGNATURE----- --YnIutncTLXsDZs5t--