From: Viresh Kumar <viresh.kumar@linaro.org>
To: Vaishali Thakkar <vthakkar1994@gmail.com>
Cc: Zhang Rui <rui.zhang@intel.com>,
Eduardo Valentin <edubezval@gmail.com>,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] thermal: cpu_cooling: Remove usage of devm functions
Date: Thu, 20 Aug 2015 21:47:04 +0530 [thread overview]
Message-ID: <20150820161704.GD4159@linux> (raw)
In-Reply-To: <20150820161402.GA4951@localhost>
On 20-08-15, 21:44, Vaishali Thakkar wrote:
> In the function cpufreq_get_requested_power, the memory allocated
> for load_cpu is live within the function only. And after the
> allocation it is immediately freed with devm_kfree. There is no
> need to allocate memory for load_cpu with devm function so replace
> devm_kcalloc with kcalloc and devm_kfree with kfree.
>
> Signed-off-by: Vaishali Thakkar <vthakkar1994@gmail.com>
> ---
> Changes since v1:
> - Introduce new label based on Viresh Kumar's suggestion
> ---
> drivers/thermal/cpu_cooling.c | 20 +++++++++-----------
> 1 file changed, 9 insertions(+), 11 deletions(-)
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
--
viresh
next prev parent reply other threads:[~2015-08-20 16:17 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-20 16:14 [PATCH v2] thermal: cpu_cooling: Remove usage of devm functions Vaishali Thakkar
2015-08-20 16:17 ` Viresh Kumar [this message]
2015-08-26 12:47 ` Javi Merino
2015-08-26 12:51 ` Viresh Kumar
2015-08-26 13:09 ` Javi Merino
2015-08-26 13:14 ` Viresh Kumar
2015-08-27 1:31 ` Vaishali Thakkar
2015-08-27 9:00 ` Javi Merino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150820161704.GD4159@linux \
--to=viresh.kumar@linaro.org \
--cc=edubezval@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rui.zhang@intel.com \
--cc=vthakkar1994@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.