From: Alexander Kuleshov <kuleshovmail@gmail.com>
To: Jiri Kosina <jikos@kernel.org>
Cc: Alexander Kuleshov <kuleshovmail@gmail.com>,
Henrik Rydberg <rydberg@bitmath.org>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] drivers/hid: Check result of debugfs_create_dir() and debugfs_create_file()
Date: Thu, 20 Aug 2015 23:38:47 +0600 [thread overview]
Message-ID: <20150820173847.GA1821@localhost> (raw)
In-Reply-To: <alpine.LNX.2.00.1508192240080.25821@pobox.suse.cz>
Hello Jiri,
On 08-19-15, Jiri Kosina wrote:
> On Wed, 19 Aug 2015, Alexander Kuleshov wrote:
>
> >
> > - hid_debug_init();
> > + if (hid_debug)
> > + hid_debug_init();
>
> How is this change related to the rest of the patch?
>
> It's wrong anyway, because hid_debug is independent of the debugfs HID
> debugging facility. Please see for example the printk() a few lines above
> in this very function, which is emited in case hid_debug is enabled.
>
hmm, I thought that these things are related. I've remove all hid_debug check
and sent v3 of the patch.
prev parent reply other threads:[~2015-08-20 17:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-18 18:35 [PATCH v2] drivers/hid: Check result of debugfs_create_dir() and debugfs_create_file() Alexander Kuleshov
2015-08-19 20:41 ` Jiri Kosina
2015-08-20 17:38 ` Alexander Kuleshov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150820173847.GA1821@localhost \
--to=kuleshovmail@gmail.com \
--cc=jikos@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rydberg@bitmath.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.