From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:770:15f::2]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 871E71A0103 for ; Fri, 21 Aug 2015 04:29:19 +1000 (AEST) Date: Thu, 20 Aug 2015 20:29:03 +0200 From: Peter Zijlstra To: Kevin Hao Cc: Michael Ellerman , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, Ingo Molnar , Benjamin Herrenschmidt Subject: Re: [PATCH 1/8] jump_label: no need to acquire the jump_label_mutex in jump_lable_init() Message-ID: <20150820182903.GA3161@worktop.event.rightround.com> References: <1440072876-8321-1-git-send-email-haokexin@gmail.com> <1440072876-8321-2-git-send-email-haokexin@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <1440072876-8321-2-git-send-email-haokexin@gmail.com> List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Thu, Aug 20, 2015 at 08:14:29PM +0800, Kevin Hao wrote: > The jump_label_init() run in a very early stage, even before the > sched_init(). So there is no chance for concurrent access of the > jump label table. It also doesn't hurt to have it. Its better to be consistent and conservative with locking unless there is a pressing need.