All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v4 2015.08 3/4] Makefile: implement a size-stats target
Date: Thu, 20 Aug 2015 22:43:56 +0200	[thread overview]
Message-ID: <20150820224356.12a399bb@free-electrons.com> (raw)
In-Reply-To: <CAMQcK5KM=uRUNOZSqu1vieRe4rc5c8+X6WJE5=M_PFxdbo-42w@mail.gmail.com>

Ryan,

On Thu, 20 Aug 2015 07:42:39 -0500, Ryan Barnett wrote:

> > +size-stats:
> > +       $(Q)mkdir -p $(GRAPHS_DIR)
> > +       $(Q)$(TOPDIR)/support/scripts/size-stats --builddir $(BASE_DIR) \
> > +               --graph $(BASE_DIR)/graphs/graph-size.$(BR_GRAPH_OUT) \
> > +               --file-size-csv $(BASE_DIR)/build/file-size-stats.csv \
> > +               --package-size-csv $(BASE_DIR)/build/package-size-stats.csv \
> > +               --skeleton-path $(TARGET_SKELETON)
> 
> In order to make this patch series to continue to work with the recent
> addition of the skeleton package, the --skeleton-path variable needs
> to be updated to:
> 
>    --skeleton-path $(SKELETON_PATH)
> 
> I don't know if you have already updated this or not in your patch
> series but this change needs to be in order to have the graph
> statistics work.

I haven't had the time to update the series unfortunately. However, now
that the skeleton is a real package, I believe all the special handling
of the skeleton can be removed from this size-stats mechanism. It will
simply be handled as a normal package.

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

  reply	other threads:[~2015-08-20 20:43 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-25 21:56 [Buildroot] [PATCH v4 2015.08 0/4] Generate package size statistics Thomas Petazzoni
2015-05-25 21:56 ` [Buildroot] [PATCH v4 2015.08 1/4] pkg-generic: add step_pkg_size global instrumentation hook Thomas Petazzoni
2015-05-28  3:29   ` Ryan Barnett
2015-07-11 10:46   ` Romain Naour
2015-07-11 11:09     ` Thomas Petazzoni
2015-05-25 21:56 ` [Buildroot] [PATCH v4 2015.08 2/4] support/scripts: add size-stats script Thomas Petazzoni
2015-05-28  3:18   ` Ryan Barnett
2015-05-28 14:55     ` Matthew Weber
2015-09-02 21:08     ` Thomas Petazzoni
2015-06-03 15:50   ` Clayton Shotwell
2015-07-11 11:46     ` Romain Naour
2015-05-25 21:56 ` [Buildroot] [PATCH v4 2015.08 3/4] Makefile: implement a size-stats target Thomas Petazzoni
2015-05-28  3:32   ` Ryan Barnett
2015-08-20 12:42   ` Ryan Barnett
2015-08-20 20:43     ` Thomas Petazzoni [this message]
2015-08-21 14:07       ` Ryan Barnett
2015-08-23 14:46         ` Thomas Petazzoni
2015-05-25 21:56 ` [Buildroot] [PATCH v4 2015.08 4/4] docs/manual: add section about size graphing Thomas Petazzoni
2015-05-28  3:42   ` Ryan Barnett
2015-07-30 21:54 ` [Buildroot] [PATCH v4 2015.08 0/4] Generate package size statistics Ryan Barnett

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150820224356.12a399bb@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.