All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dave Chinner <david@fromorbit.com>
To: Jan Tulak <jtulak@redhat.com>
Cc: Christoph Hellwig <hch@infradead.org>, xfs-oss <xfs@oss.sgi.com>
Subject: Re: [PATCH 05/11] xfsprogs: missing and dummy calls for OS X support
Date: Fri, 21 Aug 2015 10:43:27 +1000	[thread overview]
Message-ID: <20150821004326.GW714@dastard> (raw)
In-Reply-To: <CACj3i70p4mfqs9HZbxzbnJaGXB=vxNHPUggx183Z_yLYHdP9PA@mail.gmail.com>

On Thu, Aug 20, 2015 at 09:33:33AM +0200, Jan Tulak wrote:
> On Thu, Aug 20, 2015 at 2:22 AM, Dave Chinner <david@fromorbit.com> wrote:
> 
> > On Wed, Aug 19, 2015 at 08:26:23PM +1000, Dave Chinner wrote:
> > > On Wed, Aug 19, 2015 at 01:09:40AM -0700, Christoph Hellwig wrote:
> > > > On Wed, Aug 19, 2015 at 07:45:57AM +1000, Dave Chinner wrote:
> > > > > Hmmm, looks like I accidentally comitted an earlier version of this
> > > > > patch yesterday. Jan, can you send delta patches to what I committed
> > > > > to address more recent review comments? Sorry, my bad.
> > > >
> > > > Can you revert it for now? I think most of these changes are incorrect
> > > > and should either be dropped for now by disabling fsx or will need
> > > > a major rework.
> > >
> > > I'll just rebase the for-next branch, I guess, and remove it
> > > completely from the history. I've got another lockdep fix that needs
> > > to be pushed before it all hits tomorrow's linux-next build, anyway.
> >
> > Getting my trees mixed up. I'll revert the patch on the next push.
> 
> 
> ​And as I noticed, '
> xfsprogs: Add includes required for OS X builds
> ​' was ​also
> selected in an older version. Other patches looks OK, though. :-)
> Should I send delta patch for that one? It is just about three #includes.

Yes.

Cheers,

Dave.
-- 
Dave Chinner
david@fromorbit.com

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

  reply	other threads:[~2015-08-21  0:51 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-17 16:23 [PATCH 00/11] xfsprogs: Partial OS X support Jan Tulak
2015-08-17 16:23 ` [PATCH 01/11] xfsprogs: undefined variable fix Jan Tulak
2015-08-17 19:22   ` Christoph Hellwig
2015-08-17 16:23 ` [PATCH 02/11] xfsprogs: Add ifdef dirent checks where it was missing Jan Tulak
2015-08-17 19:23   ` Christoph Hellwig
2015-08-18  6:49     ` Jan Tulak
2015-08-17 16:23 ` [PATCH 03/11] xfsprogs: Change OS X-specific CFLAGS/LDFLAGS Jan Tulak
2015-08-17 16:23 ` [PATCH 04/11] xfsprogs: Add includes required for OS X builds Jan Tulak
2015-08-17 19:23   ` Christoph Hellwig
2015-08-17 16:23 ` [PATCH 05/11] xfsprogs: missing and dummy calls for OS X support Jan Tulak
2015-08-17 19:32   ` Christoph Hellwig
2015-08-18  0:17     ` Dave Chinner
2015-08-24 12:53     ` Jan Tulak
2015-08-18 21:45   ` Dave Chinner
2015-08-19  8:09     ` Christoph Hellwig
2015-08-19  9:14       ` Jan Tulak
2015-08-19  9:19         ` Christoph Hellwig
2015-08-19 10:26       ` Dave Chinner
2015-08-20  0:22         ` Dave Chinner
2015-08-20  7:33           ` Jan Tulak
2015-08-21  0:43             ` Dave Chinner [this message]
2015-08-17 16:23 ` [PATCH 06/11] xfsprogs: Add mntent.h check into autoconf Jan Tulak
2015-08-17 19:32   ` Christoph Hellwig
2015-08-17 16:23 ` [PATCH 07/11] xfsprogs: Add fls " Jan Tulak
2015-08-17 19:32   ` Christoph Hellwig
2015-08-17 16:23 ` [PATCH 08/11] xfsprogs: replace obsolete memalign with posix_memalign Jan Tulak
2015-08-17 19:36   ` Christoph Hellwig
2015-08-18  7:04     ` Jan Tulak
2015-08-18  8:20       ` Dave Chinner
2015-08-18  8:33         ` Jan Tulak
2015-08-18 22:01           ` Dave Chinner
2015-08-19  8:06             ` Jan Tulak
2015-08-17 16:23 ` [PATCH 09/11] xfsprogs: prevent LIST_ macros conflicts Jan Tulak
2015-08-17 19:36   ` Christoph Hellwig
2015-08-17 16:23 ` [PATCH 10/11] xfsprogs: Update doc for OS X Jan Tulak
2015-08-17 19:36   ` Christoph Hellwig
2015-08-17 16:23 ` [PATCH 11/11] xfsprogs: Add a way to compile without blkid Jan Tulak
2015-08-17 19:39   ` Christoph Hellwig
2015-08-18  7:59     ` Jan Tulak
2015-08-18 12:02     ` [PATCH v2 " Jan Tulak
2015-08-17 21:55 ` [PATCH 00/11] xfsprogs: Partial OS X support Dave Chinner
2015-08-18  9:14   ` Jan Tulak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150821004326.GW714@dastard \
    --to=david@fromorbit.com \
    --cc=hch@infradead.org \
    --cc=jtulak@redhat.com \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.