From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: [PATCH 0/7] gpio: omap: fixes and improvements Date: Fri, 21 Aug 2015 01:13:43 -0700 Message-ID: <20150821081342.GL4215@atomide.com> References: <1439896258-26449-1-git-send-email-grygorii.strashko@ti.com> <20150819063851.GI4215@atomide.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from muru.com ([72.249.23.125]:45574 "EHLO muru.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751769AbbHUINr (ORCPT ); Fri, 21 Aug 2015 04:13:47 -0400 Content-Disposition: inline In-Reply-To: <20150819063851.GI4215@atomide.com> Sender: linux-gpio-owner@vger.kernel.org List-Id: linux-gpio@vger.kernel.org To: Grygorii Strashko Cc: Linus Walleij , Alexandre Courbot , ssantosh@kernel.org, Kevin Hilman , Javier Martinez Canillas , linux-omap@vger.kernel.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org * Tony Lindgren [150818 23:42]: > Hi, > > * Grygorii Strashko [150818 04:14]: > > Hi, > > > > This patch series contains set of trivial fixes and improvements, and also > > patches which fixes wrong APIs usage in atomic context as for -RT as for > > non-RT kernel. The final goal of this series is to make TI OMAP GPIO > > driver compatible with -RT kernel as much as possible. > > > > Patch 1-4: trivial fixes and improvements > > Patch 5: fixes wrong CLK clk_prepare/unprepare APIs usage in atomic contexet > > Patch 6(rfc): required to be compatible with -RT kernel, because PM runtime > > can't be used in atimic context on -RT. > > Patch 7(rfc): This patch converts TI OMAP GPIO driver to use generic irq > > handler instead of chained IRQ handler. This way OMAP GPIO driver will be > > compatible with RT kernel where it will be forced thread IRQ handler > > while in non-RT kernel it still will be executed in HW IRQ context. > > Based on quick testing this series breaks at least core off idle for omap3. > You probably should add a beagle xm to your test devices so you can > properly test PM features. Sorry I take that back, after trying to figure out which patch breaks PM I noticed I had some other patches applied also. Looks like PM works just fine with this series for me, so please feel free to add: Tested-by: Tony Lindgren Note that I have not been able to test this with gpio button as my boards are in a rack. You may want to do some gpio button tests to make sure things wake up properly from off idle if you can get hold of a beagle xm. I posted some instructions how to test earlier today for Kishon in the "[PATCH v2 00/16] omap_hsmmc: regulator usage cleanup and fixes" thread. Regards, Tony