From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pekka Paalanen Subject: Re: [PATCH 2/6] xf86drmMode: separate drmModeAtomicCommit() and drmModeAtomicCleanup() Date: Fri, 21 Aug 2015 09:42:26 +0300 Message-ID: <20150821094226.4c2a23c3@gmail.com> References: <1439945924-22630-1-git-send-email-human.hwang@samsung.com> <1439945924-22630-2-git-send-email-human.hwang@samsung.com> <20150821135449.6e2c5b00@samsung.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1588875613==" Return-path: Received: from mail-lb0-f174.google.com (mail-lb0-f174.google.com [209.85.217.174]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7EA186E577 for ; Thu, 20 Aug 2015 23:42:39 -0700 (PDT) Received: by lbcbn3 with SMTP id bn3so37607347lbc.2 for ; Thu, 20 Aug 2015 23:42:37 -0700 (PDT) In-Reply-To: <20150821135449.6e2c5b00@samsung.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Hyungwon Hwang Cc: Emil Velikov , ML dri-devel List-Id: dri-devel@lists.freedesktop.org --===============1588875613== Content-Type: multipart/signed; micalg=pgp-sha256; boundary="Sig_/4u_vUWzA/IhmD4w=8A.YGpn"; protocol="application/pgp-signature" --Sig_/4u_vUWzA/IhmD4w=8A.YGpn Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable On Fri, 21 Aug 2015 13:54:49 +0900 Hyungwon Hwang wrote: > Hi Emil, >=20 > On Thu, 20 Aug 2015 17:17:27 +0100 > Emil Velikov wrote: >=20 > > Hi Hyungwon, > >=20 > > On 19 August 2015 at 01:58, Hyungwon Hwang > > wrote: > > > This patch seprates the code, which sorts proprty sets and > > > eliminates duplicate properties, from drmModeAtomicCommit(). Now > > > drmModeAtomicCleanup() has to do the job before calling > > > drmModeAtomicCommit(), and drmModeAtomicCommit() just converts the > > > cleaned request to IOCTL argument. > > > > > Afaict the commit message should say why we want this, rather than > > rewording what the patch does. > >=20 > > I'm not sure about the atomic status for wayland and others but this > > commit might cause issues there. Additionally, with this patch we'll > > send a lot of useless information to the kernel if one omits > > drmModeAtomicCleanup(). The kernel will likely discard it but still > > this doesn't seem like a good idea imho. >=20 > Yes. I agree that this change burdens the userspace application to use > API correctly. In my case, for modetest, the function of cleaning up > the request is needed, so I thought that this separation would be > needed. Overall, I agree with you. So I will drop this patch, and find > another way which is specific for modetest. Hi, why do you need that, exactly? Thanks, pq --Sig_/4u_vUWzA/IhmD4w=8A.YGpn Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIVAwUBVdbIWCNf5bQRqqqnAQh+dxAAqKyrBBbjrWj6MtL98y6oqWKi1i2NjOyq Xp9gIY0KEi5DMn3C2yBHE/rMSl9Z1F+Yve6wtIw/gHN0j44+0QMrVB775iU/sMjs H8v3DWZG8J3WyV3zxEMvbS8TR4aZ0zEL6o3/VuPC0HhH941b8TxIoPllmbGo4QFb Ignrd/iL32yil2NEjYSi/gpISo6jgccW4Dq2BL4NGDB+0LdLBSQTbBNt0AzDFEw+ 3i8vJZKB8ecq1CNlhONKd/xGT/Es15LRYb//X+G9EXgjHLHfKJu/1N91Lgu9HR9i 6viIIrRaTg9RFXlRmaz9G/Our9nAfBNC0D6CgmMa21KCBf/caE5m9RJ2pP0b81+C cZ+GUhuHt9iksnSYSwIZfFFP05vUxbHGUIWdtbyqHZoNDAyb7Cv4lsJBaM2G7h2B hqxKF1xc+edWgUOWMpi6pXb1oRzQSPErvyHl1oQ+cRVZZasEFrJVJpbTLMMi7Lso Mof1PXKDFrxn+/P3uTRkfjVT9ICveFx6Js5wfCwJn1sbhkhlpGKAA4GjiJZb76YD 4XGEoslgbXxgEKuS87njYLtY/WQ5rlFs0deAJ71Cj0aOPYaZlcrumrBBa8xFLdTd YZ8L470Bmp8NyflWTmaAmCm4/bcCN53BiOJZkC7XRtvUYsF7IXdc+bwgsTi+kGRe A7f3BJGFXiU= =C7tQ -----END PGP SIGNATURE----- --Sig_/4u_vUWzA/IhmD4w=8A.YGpn-- --===============1588875613== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0 cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK --===============1588875613==--