From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pekka Paalanen Subject: Re: [PATCH 3/6] xf86drmMode: Make atomic request structures visible Date: Fri, 21 Aug 2015 09:44:42 +0300 Message-ID: <20150821094442.7ebc6b39@gmail.com> References: <1439945924-22630-1-git-send-email-human.hwang@samsung.com> <1439945924-22630-3-git-send-email-human.hwang@samsung.com> <20150821150658.50d3f2be@samsung.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0172131338==" Return-path: Received: from mail-la0-f42.google.com (mail-la0-f42.google.com [209.85.215.42]) by gabe.freedesktop.org (Postfix) with ESMTPS id 009626E7EF for ; Thu, 20 Aug 2015 23:44:52 -0700 (PDT) Received: by lagz9 with SMTP id z9so35695551lag.3 for ; Thu, 20 Aug 2015 23:44:51 -0700 (PDT) In-Reply-To: <20150821150658.50d3f2be@samsung.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Hyungwon Hwang Cc: Emil Velikov , ML dri-devel List-Id: dri-devel@lists.freedesktop.org --===============0172131338== Content-Type: multipart/signed; micalg=pgp-sha256; boundary="Sig_/PGXP+jaSZlkSsU0mMtw0EWW"; protocol="application/pgp-signature" --Sig_/PGXP+jaSZlkSsU0mMtw0EWW Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable On Fri, 21 Aug 2015 15:06:58 +0900 Hyungwon Hwang wrote: > Hi Emil, >=20 > On Thu, 20 Aug 2015 17:23:09 +0100 > Emil Velikov wrote: >=20 > > On 19 August 2015 at 01:58, Hyungwon Hwang > > wrote: > > > This patch makes 'struct _drmModeAtomicReqItem' and 'struct > > > _drmModeAtomicReq' visible from outside. This is needed for > > > userspace applications to use those structures when calling > > > drmModeAtomicCommit(). Yeah, this sounds like a very bad idea. Thanks, pq > > > > > Hmmm what is missing in the current API, that one needs direct access > > to the structs ? If we expose these to the user we'll be putting a > > (ABI) hedgehog down our pants (i.e. it might be ok, but will likely > > result in a very painful experience). >=20 > I also agree with you. I think I should drop this patch, and find > another way for modetest. --Sig_/PGXP+jaSZlkSsU0mMtw0EWW Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIVAwUBVdbI4CNf5bQRqqqnAQi99hAAnCaHuUNkuRZgiECthWAhqkViQgzJjwWV +XHbAMJr//zLMEpPwc0yGyzyra80dFc0RGvAKYAQBQSsOcZxekdXVvpVY3TyFzc8 yvS6XtXBBHC0R6bg0hoNTQDxNanwmuE0oUbTtnpx3eTNorK+uhhtU3mckVWmmO8M LsgJHmOEp5A1/X+hTPwGQ0afAH6tlMbXH144qVWhuZ7Mrtl1iIgu8D41FW4y+S36 rtC2DD4duZYtvibgS9T0Akt0z2jUIAIlWVMXw7COOMIGAMBl8ffctblMX2P7WQ5N ueYDDEoMVTaPZpSGRahk1s3pre+FpCuCd/7pGpUx3uXy0o3U9OKR+Yq9bKOxrQuy SibZuAFQYWn0Sy+AVdmoR3eK8nBQWosUiTwy17e6gElbRw1e09e3RpsihK3MAhr7 QQ7MM1So2EnixSNaCtsM51EZSI1E+pSVb2PXMlQljF1bs/3VHDOZr7BraZ2nLL5a R+Np0b4ecUrWa5D50h1ZBSdSd/rATbFBQdLGVq+cZbWX1r8q5xa4J44Yo+eIJm7q 71IMGlLN9ryACDN/IKS2SPbS3ZCarzQ9Ug7uBVlijjstuiaD5eJm+7MQ/ZdzM3Ep GzTp1gxiEGVfmC3mi8yrvsEaQ0FIEWv1sQOTu/lQcg4vU+4mr/dG9TMriRp7wJVe DoMvlo8TRT8= =8fFi -----END PGP SIGNATURE----- --Sig_/PGXP+jaSZlkSsU0mMtw0EWW-- --===============0172131338== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0 cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK --===============0172131338==--