All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Ruder <andy@aeruder.net>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH V2 3/5] dm9000: Add struct eth_device * to SROM functions
Date: Fri, 21 Aug 2015 06:25:58 -0500	[thread overview]
Message-ID: <20150821112558.GA21772@og3k.com> (raw)
In-Reply-To: <CANr=Z=bvk3Puzc9hLxOwq6eV8oon_iMoa6_hq0vzm=CTNMK9DQ@mail.gmail.com>

On Wed, Aug 12, 2015 at 02:07:20PM -0500, Joe Hershberger wrote:
> On Wed, Aug 12, 2015 at 12:24 PM, Andrew Ruder
> <andrew.ruder@elecsyscorp.com> wrote:
> >  /******************  function prototypes **********************/
> >  #if !defined(CONFIG_DM9000_NO_SROM)
> > -void dm9000_write_srom_word(int offset, u16 val);
> > -void dm9000_read_srom_word(int offset, u8 *to);
> > +struct eth_device;
> > +
> > +void dm9000_write_srom_word(struct eth_device *dev, int offset, u16 val);
> > +void dm9000_read_srom_word(struct eth_device *dev, int offset, u8 *to);
> 
> It will be better to pass the dm9000_priv* instead. See patch 5 for details.

Even on the "public"-facing functions?

Thanks,
Andrew

  reply	other threads:[~2015-08-21 11:25 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-12 17:24 [U-Boot] [PATCH V2 0/5] DM9000 support for multiple interfaces Andrew Ruder
2015-08-12 17:24 ` [U-Boot] [PATCH V2 1/5] dm9000: whitespace cleanups Andrew Ruder
2015-08-12 19:07   ` Joe Hershberger
2015-08-12 17:24 ` [U-Boot] [PATCH V2 2/5] dm9000: mark dump_regs() function as unused Andrew Ruder
2015-08-12 19:07   ` Joe Hershberger
2015-08-12 17:24 ` [U-Boot] [PATCH V2 3/5] dm9000: Add struct eth_device * to SROM functions Andrew Ruder
2015-08-12 19:07   ` Joe Hershberger
2015-08-21 11:25     ` Andrew Ruder [this message]
2015-08-21 15:56       ` Joe Hershberger
2015-08-12 17:24 ` [U-Boot] [PATCH V2 4/5] dm9000: dm9000_initialize stub Andrew Ruder
2015-08-12 19:07   ` Joe Hershberger
2015-08-16  0:51   ` Marcel Ziswiler
2015-08-16  1:15     ` Marcel Ziswiler
2015-08-12 17:24 ` [U-Boot] [PATCH V2 5/5] dm9000: rework dm9000 to support multiple devices Andrew Ruder
2015-08-12 19:07   ` Joe Hershberger
2015-08-12 17:50 ` [U-Boot] [PATCH V2 0/5] DM9000 support for multiple interfaces Andrew Ruder

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150821112558.GA21772@og3k.com \
    --to=andy@aeruder.net \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.