From: Mike Rapoport <mike.rapoport@gmail.com>
To: Aparna Karuthodi <kdasaparna@gmail.com>
Cc: gregkh@linuxfoundation.org, thomas.petazzoni@free-electrons.com,
linux-kernel@vger.kernel.org, noralf@tronnes.org,
devel@driverdev.osuosl.org
Subject: Re: [PATCH] staging: fbtft: Removed a space
Date: Fri, 21 Aug 2015 15:34:22 +0300 [thread overview]
Message-ID: <20150821123422.GA3915@zed> (raw)
In-Reply-To: <1440159928-5269-1-git-send-email-kdasaparna@gmail.com>
On Fri, Aug 21, 2015 at 05:55:28PM +0530, Aparna Karuthodi wrote:
> Okay. I will make the necessary changes and send it again.
> If I am making changes in each of the lines, should I send it as a
> patchset?
It seems that these checkpatch errors were already fixed in commit that
was already merged:
commit 171c44fcbbf243a327cd2667a74b59b871489b91
Author: Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>
Date: Tue Feb 17 19:48:51 2015 +0200
staging: fbtft: fix spacing errors
Are you sure you have the recent kernel tree?
> Signed-off-by: Aparna Karuthodi <kdasaparna@gmail.com>
> ---
> drivers/staging/fbtft/fb_bd663474.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/fbtft/fb_bd663474.c b/drivers/staging/fbtft/fb_bd663474.c
> index 7e00c60..8619426 100644
> --- a/drivers/staging/fbtft/fb_bd663474.c
> +++ b/drivers/staging/fbtft/fb_bd663474.c
> @@ -115,7 +115,7 @@ static int init_display(struct fbtft_par *par)
> write_reg(par, 0x100, 0x7120 );
> write_reg(par, 0x007, 0x0103 );
> mdelay( 10 );
> - write_reg(par, 0x007, 0x0113 );
> + write_reg(par, 0x007, 0x0113);
>
> return 0;
> }
> --
> 1.7.9.5
--
Sincerely yours,
Mike.
next prev parent reply other threads:[~2015-08-21 12:34 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-20 13:56 [PATCH] staging: fbtft: Removed a space Aparna Karuthodi
2015-08-21 11:04 ` Dan Carpenter
2015-08-21 12:25 ` Aparna Karuthodi
2015-08-21 12:34 ` Mike Rapoport [this message]
2015-08-21 13:01 ` Aparna Karuthodi
2015-08-21 13:26 ` Mike Rapoport
2015-09-03 1:10 ` Greg KH
2015-08-21 13:43 ` Aparna Karuthodi
2015-08-21 15:35 ` [PATCH] staging: fbtft: Removed space before parenthesis Aparna Karuthodi
2015-08-24 13:06 ` Sudip Mukherjee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150821123422.GA3915@zed \
--to=mike.rapoport@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=kdasaparna@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=noralf@tronnes.org \
--cc=thomas.petazzoni@free-electrons.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.