From: Olof Johansson <olof@lixom.net>
To: Javier Martinez Canillas <javier@osg.samsung.com>
Cc: linux-kernel@vger.kernel.org,
Gwendal Grignou <gwendal@chromium.org>,
Doug Anderson <dianders@chromium.org>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Wolfram Sang <wsa@the-dreams.de>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Lee Jones <lee.jones@linaro.org>,
Geert Uytterhoeven <geert@linux-m68k.org>
Subject: Re: [PATCH 3/6] platform/chrome: Make depends on MFD_CROS_EC instead CROS_EC_PROTO
Date: Fri, 21 Aug 2015 10:03:53 -0700 [thread overview]
Message-ID: <20150821170353.GB26236@localhost> (raw)
In-Reply-To: <1439983198-4696-4-git-send-email-javier@osg.samsung.com>
On Wed, Aug 19, 2015 at 01:19:55PM +0200, Javier Martinez Canillas wrote:
> The ChromeOS EC LPC and chardev drivers depend on CROS_EC_PROTO but
> MFD_CROS_EC select CROS_EC_PROTO instead. Mixing select and depends
> on is bad practice as it may lead to circular Kconfig dependencies.
>
> Since the platform devices that are matched with these drivers are
> registered by the ChromeOS EC mfd driver, they really depend on
> MFD_CROS_EC. And because this config option selects CROS_EC_PROTO,
> that dependency is met as well. So make the drivers to depend on
> MFD_CROS_EC instead of CROS_EC_PROTO.
>
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
Applied, thanks.
next prev parent reply other threads:[~2015-08-21 17:12 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-19 11:19 [PATCH 0/6] ChromeOS EC Kconfig cleanups Javier Martinez Canillas
2015-08-19 11:19 ` Javier Martinez Canillas
2015-08-19 11:19 ` [PATCH 1/6] mfd: Add MFD_CROS_EC dependencies Javier Martinez Canillas
2015-08-19 13:00 ` Lee Jones
2015-08-19 11:19 ` [PATCH 2/6] Revert "platform/chrome: Don't make CHROME_PLATFORMS depends on X86 || ARM" Javier Martinez Canillas
2015-08-21 17:03 ` Olof Johansson
2015-08-19 11:19 ` [PATCH 3/6] platform/chrome: Make depends on MFD_CROS_EC instead CROS_EC_PROTO Javier Martinez Canillas
2015-08-21 17:03 ` Olof Johansson [this message]
2015-08-19 11:19 ` [PATCH 4/6] mfd: cros_ec: Remove CROS_EC_PROTO dependency for SPI and I2C drivers Javier Martinez Canillas
2015-08-19 12:59 ` Lee Jones
[not found] ` <1439983198-4696-1-git-send-email-javier-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org>
2015-08-19 11:19 ` [PATCH 5/6] i2c: Replace I2C_CROS_EC_TUNNEL dependency Javier Martinez Canillas
2015-08-19 11:19 ` Javier Martinez Canillas
[not found] ` <1439983198-4696-6-git-send-email-javier-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org>
2015-08-24 12:18 ` Wolfram Sang
2015-08-24 12:18 ` Wolfram Sang
2015-08-19 11:19 ` [PATCH 6/6] Input: Replace KEYBOARD_CROS_EC dependency Javier Martinez Canillas
2015-08-19 21:26 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150821170353.GB26236@localhost \
--to=olof@lixom.net \
--cc=b.zolnierkie@samsung.com \
--cc=dianders@chromium.org \
--cc=dmitry.torokhov@gmail.com \
--cc=geert@linux-m68k.org \
--cc=gwendal@chromium.org \
--cc=javier@osg.samsung.com \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.