From: Olof Johansson <olof@lixom.net>
To: Christian Engelmayer <cengelma@gmx.at>
Cc: lee.jones@linaro.org, gwendal@chromium.org,
wfrichar@chromium.org, smbarber@chromium.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mfd: cros_ec: Fix possible leak in led_rgb_store()
Date: Fri, 21 Aug 2015 10:11:27 -0700 [thread overview]
Message-ID: <20150821171127.GF26236@localhost> (raw)
In-Reply-To: <1437334982-3388-1-git-send-email-cengelma@gmx.at>
On Sun, Jul 19, 2015 at 09:43:02PM +0200, Christian Engelmayer wrote:
> Function led_rgb_store() contains some direct returns in error cases that
> leak the already allocated cros_ec_command message structure. Make sure
> that 'msg' is freed in all exit paths. Detected by Coverity CID 1309666.
>
> Signed-off-by: Christian Engelmayer <cengelma@gmx.at>
> ---
> Compile tested only. Applies against linux-next.
Applied with adjusted patch subject.
-Olof
prev parent reply other threads:[~2015-08-21 17:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-19 19:43 [PATCH] mfd: cros_ec: Fix possible leak in led_rgb_store() Christian Engelmayer
2015-07-20 14:50 ` Gwendal Grignou
2015-07-20 20:57 ` Christian Engelmayer
2015-07-23 15:19 ` Lee Jones
2015-08-21 17:11 ` Olof Johansson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150821171127.GF26236@localhost \
--to=olof@lixom.net \
--cc=cengelma@gmx.at \
--cc=gwendal@chromium.org \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=smbarber@chromium.org \
--cc=wfrichar@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.