From: Oleg Nesterov <oleg@redhat.com>
To: Paul McKenney <paulmck@linux.vnet.ibm.com>
Cc: Ingo Molnar <mingo@redhat.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
Peter Zijlstra <peterz@infradead.org>, Tejun Heo <tj@kernel.org>,
linux-kernel@vger.kernel.org
Subject: [PATCH v2 5/8] percpu-rwsem: make percpu_free_rwsem() after kzalloc() safe
Date: Fri, 21 Aug 2015 19:42:55 +0200 [thread overview]
Message-ID: <20150821174255.GA17903@redhat.com> (raw)
In-Reply-To: <20150821174230.GA17867@redhat.com>
This is the temporary ugly hack which will be reverted later. We only
need it to ensure that the next patch will not break "change sb_writers
to use percpu_rw_semaphore" patches routed via VFS tree.
alloc_super()->destroy_super() error path assumes that it is safe to
call percpu_free_rwsem() after kzalloc() without percpu_init_rwsem(),
let's not dissapoint it.
Signed-off-by: Oleg Nesterov <oleg@redhat.com>
---
kernel/locking/percpu-rwsem.c | 7 +++++++
1 files changed, 7 insertions(+), 0 deletions(-)
diff --git a/kernel/locking/percpu-rwsem.c b/kernel/locking/percpu-rwsem.c
index f325672..3bb2dc9 100644
--- a/kernel/locking/percpu-rwsem.c
+++ b/kernel/locking/percpu-rwsem.c
@@ -25,6 +25,13 @@ int __percpu_init_rwsem(struct percpu_rw_semaphore *brw,
void percpu_free_rwsem(struct percpu_rw_semaphore *brw)
{
+ /*
+ * XXX: temporary kludge. The error path in alloc_super()
+ * assumes that percpu_free_rwsem() is safe after kzalloc().
+ */
+ if (!brw->fast_read_ctr)
+ return;
+
free_percpu(brw->fast_read_ctr);
brw->fast_read_ctr = NULL; /* catch use after free bugs */
}
--
1.5.5.1
next prev parent reply other threads:[~2015-08-21 17:45 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-21 17:42 [PATCH v2 0/8] Add rcu_sync infrastructure to avoid _expedited() in percpu-rwsem Oleg Nesterov
2015-08-21 17:42 ` [PATCH v2 1/8] rcu: Create rcu_sync infrastructure Oleg Nesterov
2015-08-21 17:42 ` [PATCH v2 2/8] rcusync: Introduce struct rcu_sync_ops Oleg Nesterov
2015-08-21 17:42 ` [PATCH v2 3/8] rcusync: Add the CONFIG_PROVE_RCU checks Oleg Nesterov
2015-08-21 17:42 ` [PATCH v2 4/8] rcusync: Introduce rcu_sync_dtor() Oleg Nesterov
2015-08-21 17:42 ` Oleg Nesterov [this message]
2015-08-21 17:42 ` [PATCH v2 6/8] percpu-rwsem: change it to rely on rss_sync infrastructure Oleg Nesterov
2015-08-21 17:43 ` [PATCH v2 7/8] percpu-rwsem: fix the comments outdated by rcu_sync Oleg Nesterov
2015-08-21 17:43 ` [PATCH v2 8/8] percpu-rwsem: cleanup the lockdep annotations in percpu_down_read() Oleg Nesterov
2015-08-22 16:38 ` [PATCH v2 0/8] Add rcu_sync infrastructure to avoid _expedited() in percpu-rwsem Paul E. McKenney
2015-08-24 15:34 ` Oleg Nesterov
2015-08-24 18:31 ` parse_args() is too unforgivable? Oleg Nesterov
2015-08-25 1:24 ` Rusty Russell
2015-08-25 15:18 ` [PATCH 0/1] params: don't ignore the rest of cmdline if parse_one() fails Oleg Nesterov
2015-08-25 15:18 ` [PATCH 1/1] " Oleg Nesterov
2015-08-26 0:13 ` Rusty Russell
2015-08-26 0:22 ` [PATCH v2 0/8] Add rcu_sync infrastructure to avoid _expedited() in percpu-rwsem Paul E. McKenney
2015-08-26 12:16 ` Oleg Nesterov
2015-08-26 12:52 ` Oleg Nesterov
2015-08-26 14:29 ` Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150821174255.GA17903@redhat.com \
--to=oleg@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=paulmck@linux.vnet.ibm.com \
--cc=peterz@infradead.org \
--cc=tj@kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.