From: Alexandre Belloni <alexandre.belloni@free-electrons.com>
To: Keerthy <j-keerthy@ti.com>
Cc: tony@atomide.com, bcousson@baylibre.com, johan@kernel.org,
linux-omap@vger.kernel.org, rtc-linux@googlegroups.com,
grygorii.strashko@ti.com
Subject: [rtc-linux] Re: [PATCH v5 2/3] rtc: omap: Add internal clock enabling support
Date: Fri, 21 Aug 2015 23:36:42 +0200 [thread overview]
Message-ID: <20150821213642.GJ3769@piout.net> (raw)
In-Reply-To: <1439890876-19024-3-git-send-email-j-keerthy@ti.com>
Hi,
On 18/08/2015 at 15:11:15 +0530, Keerthy wrote :
> @@ -681,6 +688,9 @@ static int __exit omap_rtc_remove(struct platform_device *pdev)
>
> device_init_wakeup(&pdev->dev, 0);
>
> + if (!IS_ERR(rtc->clk))
> + clk_disable_unprepare(rtc->clk);
> +
> rtc->type->unlock(rtc);
> /* leave rtc running, but disable irqs */
Is it actually still running once the clock is disabled?
> rtc_write(rtc, OMAP_RTC_INTERRUPTS_REG, 0);
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
--
--
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
---
You received this message because you are subscribed to the Google Groups "rtc-linux" group.
To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
next prev parent reply other threads:[~2015-08-21 21:36 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-18 9:41 [rtc-linux] [PATCH v5 0/3] ARM: AM437X: Add rtc clock handling Keerthy
2015-08-18 9:41 ` [rtc-linux] [PATCH v5 1/3] ARM: dts: AM437x: Add the internal and external clock nodes for rtc Keerthy
2015-08-18 9:41 ` [rtc-linux] [PATCH v5 2/3] rtc: omap: Add internal clock enabling support Keerthy
2015-08-21 21:36 ` Alexandre Belloni [this message]
2015-08-24 4:39 ` [rtc-linux] " Keerthy
2015-08-18 9:41 ` [rtc-linux] [PATCH v5 3/3] rtc: omap: Add external " Keerthy
2015-08-21 21:18 ` [rtc-linux] Re: [PATCH v5 0/3] ARM: AM437X: Add rtc clock handling Alexandre Belloni
2015-08-26 16:51 ` Keerthy
2015-08-26 18:01 ` Tony Lindgren
2015-08-26 21:53 ` Alexandre Belloni
2015-09-01 15:27 ` Tony Lindgren
2015-09-01 17:18 ` Keerthy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150821213642.GJ3769@piout.net \
--to=alexandre.belloni@free-electrons.com \
--cc=bcousson@baylibre.com \
--cc=grygorii.strashko@ti.com \
--cc=j-keerthy@ti.com \
--cc=johan@kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=rtc-linux@googlegroups.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.