All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vinod Koul <vinod.koul@intel.com>
To: Jon Hunter <jonathanh@nvidia.com>
Cc: Laxman Dewangan <ldewangan@nvidia.com>,
	Stephen Warren <swarren@wwwdotorg.org>,
	Thierry Reding <thierry.reding@gmail.com>,
	Alexandre Courbot <gnurou@gmail.com>,
	dmaengine@vger.kernel.org, linux-tegra@vger.kernel.org,
	linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [RFC PATCH 1/7] DMA: tegra-apb: Correct runtime-pm usage
Date: Sun, 23 Aug 2015 19:47:07 +0530	[thread overview]
Message-ID: <20150823141707.GB13546@localhost> (raw)
In-Reply-To: <1439905755-25150-2-git-send-email-jonathanh@nvidia.com>

On Tue, Aug 18, 2015 at 02:49:09PM +0100, Jon Hunter wrote:

> @@ -1543,7 +1531,7 @@ static int tegra_dma_pm_suspend(struct device *dev)
>  	int ret;
>  
>  	/* Enable clock before accessing register */
> -	ret = tegra_dma_runtime_resume(dev);
> +	ret = pm_runtime_get_sync(dev);

why is this required ?

-- 
~Vinod

  reply	other threads:[~2015-08-23 14:17 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-18 13:49 [RFC PATCH 0/7] DMA: Add support for Tegra210 ADMA Jon Hunter
2015-08-18 13:49 ` Jon Hunter
     [not found] ` <1439905755-25150-1-git-send-email-jonathanh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2015-08-18 13:49   ` [RFC PATCH 1/7] DMA: tegra-apb: Correct runtime-pm usage Jon Hunter
2015-08-18 13:49     ` Jon Hunter
2015-08-23 14:17     ` Vinod Koul [this message]
2015-08-24  8:47       ` Jon Hunter
2015-08-24  8:47         ` Jon Hunter
2015-08-24  9:22         ` Vinod Koul
2015-08-24 13:22           ` Jon Hunter
2015-08-24 13:22             ` Jon Hunter
     [not found]             ` <55DB1AA9.7090906-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2015-08-24 14:21               ` Vinod Koul
2015-08-24 14:21                 ` Vinod Koul
2015-08-25  0:04                 ` Rafael J. Wysocki
     [not found]                   ` <13590312.K3yoQT5YDc-sKB8Sp2ER+y1GS7QM15AGw@public.gmane.org>
2015-08-25  9:37                     ` Jon Hunter
2015-08-25  9:37                       ` Jon Hunter
2015-08-25 22:46                       ` Rafael J. Wysocki
     [not found]                         ` <55DCF056.40004-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2015-08-28 10:30                           ` Jon Hunter
2015-08-28 10:30                             ` Jon Hunter
2015-08-18 13:49   ` [RFC PATCH 2/7] DMA: tegra-apb: Move code dealing with h/w registers into separate functions Jon Hunter
2015-08-18 13:49     ` Jon Hunter
2015-08-18 13:49   ` [RFC PATCH 5/7] DMA: tegra-apb: Move common code into separate source files Jon Hunter
2015-08-18 13:49     ` Jon Hunter
2015-08-18 13:49   ` [RFC PATCH 6/7] Documentation: DT: Add binding documentation for NVIDIA ADMA Jon Hunter
2015-08-18 13:49     ` Jon Hunter
2015-08-18 13:49   ` [RFC PATCH 7/7] DMA: tegra-adma: Add support for Tegra210 ADMA Jon Hunter
2015-08-18 13:49     ` Jon Hunter
     [not found]     ` <1439905755-25150-8-git-send-email-jonathanh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2015-08-23 14:33       ` Vinod Koul
2015-08-23 14:33         ` Vinod Koul
2015-08-24  8:55         ` Jon Hunter
2015-08-24  8:55           ` Jon Hunter
2015-08-24  9:24           ` Vinod Koul
2015-08-18 13:49 ` [RFC PATCH 3/7] DMA: tegra-apb: Clean-up and simplify setting up of transfer parameters Jon Hunter
2015-08-18 13:49   ` Jon Hunter
2015-08-18 13:49 ` [RFC PATCH 4/7] DMA: tegra-apb: Add a function table for functions dealing with registers Jon Hunter
2015-08-18 13:49   ` Jon Hunter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150823141707.GB13546@localhost \
    --to=vinod.koul@intel.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dmaengine@vger.kernel.org \
    --cc=gnurou@gmail.com \
    --cc=jonathanh@nvidia.com \
    --cc=ldewangan@nvidia.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=swarren@wwwdotorg.org \
    --cc=thierry.reding@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.