From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Subject: Re: [PATCH v4 3/4] mfd: Add DT binding for Maxim MAX77802 IC Date: Mon, 24 Aug 2015 12:49:01 +0100 Message-ID: <20150824114901.GC3237@x1> References: <1440406041-25071-1-git-send-email-javier@osg.samsung.com> <1440406041-25071-4-git-send-email-javier@osg.samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <1440406041-25071-4-git-send-email-javier@osg.samsung.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Javier Martinez Canillas Cc: devicetree@vger.kernel.org, Krzysztof Kozlowski , linux-samsung-soc@vger.kernel.org, Sergei Shtylyov , linux-kernel@vger.kernel.org, Mark Brown , linux-arm-kernel@lists.infradead.org List-Id: linux-samsung-soc@vger.kernel.org T24gTW9uLCAyNCBBdWcgMjAxNSwgSmF2aWVyIE1hcnRpbmV6IENhbmlsbGFzIHdyb3RlOgoKPiBU aGUgTUFYNzc4MDIgaXMgYSBjaGlwIHRoYXQgY29udGFpbnMgcmVndWxhdG9ycywgMiAzMmtIeiBj bG9ja3MsCj4gYSBSVEMgYW5kIGFuIEkyQyBpbnRlcmZhY2UgdG8gcHJvZ3JhbSB0aGUgaW5kaXZp ZHVhbCBjb21wb25lbnRzLgo+IAo+IFRoZSBhcmUgYWxyZWFkeSBEVCBiaW5kaW5ncyBmb3IgdGhl IHJlZ3VsYXRvcnMgYW5kIGNsb2NrcyBhbmQKPiB0aGVzZSByZWZlcmVuY2UgdG8gYSBiaW5kaW5n cy9tZmQvbWF4Nzc4MDIudHh0IGZpbGUsIHRoYXQgZGlkbid0Cj4gZXhpc3QsIGZvciB0aGUgZGV0 YWlscyBhYm91dCB0aGUgUE1JQy4KPiAKPiBTaWduZWQtb2ZmLWJ5OiBKYXZpZXIgTWFydGluZXog Q2FuaWxsYXMgPGphdmllckBvc2cuc2Ftc3VuZy5jb20+Cj4gUmV2aWV3ZWQtYnk6IEtyenlzenRv ZiBLb3psb3dza2kgPGsua296bG93c2tpQHNhbXN1bmcuY29tPgo+IAo+IC0tLQo+IAo+IENoYW5n ZXMgaW4gdjQ6Cj4gLSBSZXdvcmQgc2VjdGlvbiBhYm91dCBtYXg3NzgwMiBjbG9jayBhbmQgcmVn dWxhdG9yIERUIGJpbmRpbmcgZG9jcy4KPiAgIFN1Z2dlc3RlZCBieSBMZWUgSm9uZXMuCj4gLSBB bGlnbiBtYXg3NzgwMiBtZmQgcmVxdWlyZWQgcHJvcGVydGllcy4gU3VnZ2VzdGVkIGJ5IExlZSBK b25lcy4KPiAKPiBDaGFuZ2VzIGluIHYzOgo+IC0gQWRkIEtyenlzenRvZiBLb3psb3dza2kgUmV2 aWV3ZWQtYnkgdGFnIHRvIHBhdGNoICMzLgo+IC0gQ2FwaXRhbGlzZSBhbGwgYWNyb255bXMuIFN1 Z2dlc3RlZCBieSBMZWUgSm9uZXMuCj4gLSBVc2UgcmVsYXRpdmUgcGF0aCB0byByZWZlciBvdGhl ciBiaW5kaW5ncy4gU3VnZ2VzdGVkIGJ5IExlZSBKb25lcy4KPiAtIFVzZSBJUlFfVFlQRV9OT05F IGluc3RlYWQgb2YgMCBpbiBleGFtcGxlLiBTdWdnZXN0ZWQgYnkgTGVlIEpvbmVzLgo+IAo+IENo YW5nZXMgaW4gdjI6Cj4gLSBVc2UgdGhlIGNvcnJlY3QgIm1heGltLG1heDc3ODAyIiBjb21wYXRp YmxlIHN0cmluZy4KPiAgIFN1Z2dlc3RlZCBieSBLcnp5c3p0b2YgS296bG93c2tpCj4gLSBVc2Ug YSBwbWljIGdlbmVyaWMgbm9kZSBuYW1lIGZvciB0aGUgbWF4Nzc4MDIgbm9kZSBleGFtcGxlLgo+ ICAgU3VnZ2VzdGVkIGJ5IFNlcmdlaSBTaHR5bHlvdi4KPiAKPiAgRG9jdW1lbnRhdGlvbi9kZXZp Y2V0cmVlL2JpbmRpbmdzL21mZC9tYXg3NzgwMi50eHQgfCAyNiArKysrKysrKysrKysrKysrKysr KysrCj4gIDEgZmlsZSBjaGFuZ2VkLCAyNiBpbnNlcnRpb25zKCspCj4gIGNyZWF0ZSBtb2RlIDEw MDY0NCBEb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvbWZkL21heDc3ODAyLnR4dAoK QXBwbGllZCwgdGhhbmtzLgoKPiBkaWZmIC0tZ2l0IGEvRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVl L2JpbmRpbmdzL21mZC9tYXg3NzgwMi50eHQgYi9Eb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmlu ZGluZ3MvbWZkL21heDc3ODAyLnR4dAo+IG5ldyBmaWxlIG1vZGUgMTAwNjQ0Cj4gaW5kZXggMDAw MDAwMDAwMDAwLi41MWZjMWE2MGNhYTUKPiAtLS0gL2Rldi9udWxsCj4gKysrIGIvRG9jdW1lbnRh dGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL21mZC9tYXg3NzgwMi50eHQKPiBAQCAtMCwwICsxLDI2 IEBACj4gK01heGltIE1BWDc3ODAyIG11bHRpLWZ1bmN0aW9uIGRldmljZQo+ICsKPiArVGhlIE1h eGltIE1BWDc3ODAyIGlzIGEgUG93ZXIgTWFuYWdlbWVudCBJQyAoUE1JQykgdGhhdCBjb250YWlu cyAxMCBoaWdoCj4gK2VmZmljaWVuY3kgQnVjayByZWd1bGF0b3JzLCAzMiBMb3ctRHJvcE91dCAo TERPKSByZWd1bGF0b3JzIHVzZWQgdG8gcG93ZXIKPiArdXAgYXBwbGljYXRpb24gcHJvY2Vzc29y cyBhbmQgcGVyaXBoZXJhbHMsIGEgMi1jaGFubmVsIDMya0h6IGNsb2NrIG91dHB1dHMsCj4gK2Eg UmVhbC1UaW1lLUNsb2NrIChSVEMpIGFuZCBhIEkyQyBpbnRlcmZhY2UgdG8gcHJvZ3JhbSB0aGUg aW5kaXZpZHVhbAo+ICtyZWd1bGF0b3JzLCBjbG9ja3Mgb3V0cHV0cyBhbmQgdGhlIFJUQy4KPiAr Cj4gK0JpbmRpbmdzIGZvciB0aGUgYnVpbHQtaW4gMzJrIGNsb2NrIGdlbmVyYXRvciBibG9jayBh bmQKPiArcmVndWxhdG9ycyBhcmUgZGVmaW5lZCBpbiAuLi9jbGsvbWF4aW0sbWF4Nzc4MDIudHh0 IGFuZAo+ICsuLi9yZWd1bGF0b3IvbWF4Nzc4MDIudHh0IHJlc3BlY3RpdmVseS4KPiArCj4gK1Jl cXVpcmVkIHByb3BlcnRpZXM6Cj4gKy0gY29tcGF0aWJsZQkJOiBNdXN0IGJlICJtYXhpbSxtYXg3 NzgwMiIKPiArLSByZWcJCQk6IFNwZWNpZmllcyB0aGUgSTJDIHNsYXZlIGFkZHJlc3Mgb2YgUE1J QyBibG9jay4KPiArLSBpbnRlcnJ1cHRzCQk6IEkyQyBkZXZpY2UgSVJRIGxpbmUgY29ubmVjdGVk IHRvIHRoZSBtYWluIFNvQy4KPiArLSBpbnRlcnJ1cHQtcGFyZW50CTogVGhlIHBhcmVudCBpbnRl cnJ1cHQgY29udHJvbGxlci4KPiArCj4gK0V4YW1wbGU6Cj4gKwo+ICsJbWF4Nzc4MDI6IHBtaWNA MDkgewo+ICsJCWNvbXBhdGlibGUgPSAibWF4aW0sbWF4Nzc4MDIiOwo+ICsJCWludGVycnVwdC1w YXJlbnQgPSA8JmludGM+Owo+ICsJCWludGVycnVwdHMgPSA8MjYgSVJRX1RZUEVfTk9ORT47Cj4g KwkJcmVnID0gPDB4MDk+Owo+ICsJfTsKCi0tIApMZWUgSm9uZXMKTGluYXJvIFNUTWljcm9lbGVj dHJvbmljcyBMYW5kaW5nIFRlYW0gTGVhZApMaW5hcm8ub3JnIOKUgiBPcGVuIHNvdXJjZSBzb2Z0 d2FyZSBmb3IgQVJNIFNvQ3MKRm9sbG93IExpbmFybzogRmFjZWJvb2sgfCBUd2l0dGVyIHwgQmxv ZwoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgt YXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQu b3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJt LWtlcm5lbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 From: lee.jones@linaro.org (Lee Jones) Date: Mon, 24 Aug 2015 12:49:01 +0100 Subject: [PATCH v4 3/4] mfd: Add DT binding for Maxim MAX77802 IC In-Reply-To: <1440406041-25071-4-git-send-email-javier@osg.samsung.com> References: <1440406041-25071-1-git-send-email-javier@osg.samsung.com> <1440406041-25071-4-git-send-email-javier@osg.samsung.com> Message-ID: <20150824114901.GC3237@x1> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Mon, 24 Aug 2015, Javier Martinez Canillas wrote: > The MAX77802 is a chip that contains regulators, 2 32kHz clocks, > a RTC and an I2C interface to program the individual components. > > The are already DT bindings for the regulators and clocks and > these reference to a bindings/mfd/max77802.txt file, that didn't > exist, for the details about the PMIC. > > Signed-off-by: Javier Martinez Canillas > Reviewed-by: Krzysztof Kozlowski > > --- > > Changes in v4: > - Reword section about max77802 clock and regulator DT binding docs. > Suggested by Lee Jones. > - Align max77802 mfd required properties. Suggested by Lee Jones. > > Changes in v3: > - Add Krzysztof Kozlowski Reviewed-by tag to patch #3. > - Capitalise all acronyms. Suggested by Lee Jones. > - Use relative path to refer other bindings. Suggested by Lee Jones. > - Use IRQ_TYPE_NONE instead of 0 in example. Suggested by Lee Jones. > > Changes in v2: > - Use the correct "maxim,max77802" compatible string. > Suggested by Krzysztof Kozlowski > - Use a pmic generic node name for the max77802 node example. > Suggested by Sergei Shtylyov. > > Documentation/devicetree/bindings/mfd/max77802.txt | 26 ++++++++++++++++++++++ > 1 file changed, 26 insertions(+) > create mode 100644 Documentation/devicetree/bindings/mfd/max77802.txt Applied, thanks. > diff --git a/Documentation/devicetree/bindings/mfd/max77802.txt b/Documentation/devicetree/bindings/mfd/max77802.txt > new file mode 100644 > index 000000000000..51fc1a60caa5 > --- /dev/null > +++ b/Documentation/devicetree/bindings/mfd/max77802.txt > @@ -0,0 +1,26 @@ > +Maxim MAX77802 multi-function device > + > +The Maxim MAX77802 is a Power Management IC (PMIC) that contains 10 high > +efficiency Buck regulators, 32 Low-DropOut (LDO) regulators used to power > +up application processors and peripherals, a 2-channel 32kHz clock outputs, > +a Real-Time-Clock (RTC) and a I2C interface to program the individual > +regulators, clocks outputs and the RTC. > + > +Bindings for the built-in 32k clock generator block and > +regulators are defined in ../clk/maxim,max77802.txt and > +../regulator/max77802.txt respectively. > + > +Required properties: > +- compatible : Must be "maxim,max77802" > +- reg : Specifies the I2C slave address of PMIC block. > +- interrupts : I2C device IRQ line connected to the main SoC. > +- interrupt-parent : The parent interrupt controller. > + > +Example: > + > + max77802: pmic at 09 { > + compatible = "maxim,max77802"; > + interrupt-parent = <&intc>; > + interrupts = <26 IRQ_TYPE_NONE>; > + reg = <0x09>; > + }; -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org ? Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754362AbbHXLuN (ORCPT ); Mon, 24 Aug 2015 07:50:13 -0400 Received: from mail-wi0-f176.google.com ([209.85.212.176]:36380 "EHLO mail-wi0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754164AbbHXLtF (ORCPT ); Mon, 24 Aug 2015 07:49:05 -0400 Date: Mon, 24 Aug 2015 12:49:01 +0100 From: Lee Jones To: Javier Martinez Canillas Cc: devicetree@vger.kernel.org, linux-samsung-soc@vger.kernel.org, Sergei Shtylyov , Mark Brown , linux-kernel@vger.kernel.org, Krzysztof Kozlowski , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v4 3/4] mfd: Add DT binding for Maxim MAX77802 IC Message-ID: <20150824114901.GC3237@x1> References: <1440406041-25071-1-git-send-email-javier@osg.samsung.com> <1440406041-25071-4-git-send-email-javier@osg.samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1440406041-25071-4-git-send-email-javier@osg.samsung.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 24 Aug 2015, Javier Martinez Canillas wrote: > The MAX77802 is a chip that contains regulators, 2 32kHz clocks, > a RTC and an I2C interface to program the individual components. > > The are already DT bindings for the regulators and clocks and > these reference to a bindings/mfd/max77802.txt file, that didn't > exist, for the details about the PMIC. > > Signed-off-by: Javier Martinez Canillas > Reviewed-by: Krzysztof Kozlowski > > --- > > Changes in v4: > - Reword section about max77802 clock and regulator DT binding docs. > Suggested by Lee Jones. > - Align max77802 mfd required properties. Suggested by Lee Jones. > > Changes in v3: > - Add Krzysztof Kozlowski Reviewed-by tag to patch #3. > - Capitalise all acronyms. Suggested by Lee Jones. > - Use relative path to refer other bindings. Suggested by Lee Jones. > - Use IRQ_TYPE_NONE instead of 0 in example. Suggested by Lee Jones. > > Changes in v2: > - Use the correct "maxim,max77802" compatible string. > Suggested by Krzysztof Kozlowski > - Use a pmic generic node name for the max77802 node example. > Suggested by Sergei Shtylyov. > > Documentation/devicetree/bindings/mfd/max77802.txt | 26 ++++++++++++++++++++++ > 1 file changed, 26 insertions(+) > create mode 100644 Documentation/devicetree/bindings/mfd/max77802.txt Applied, thanks. > diff --git a/Documentation/devicetree/bindings/mfd/max77802.txt b/Documentation/devicetree/bindings/mfd/max77802.txt > new file mode 100644 > index 000000000000..51fc1a60caa5 > --- /dev/null > +++ b/Documentation/devicetree/bindings/mfd/max77802.txt > @@ -0,0 +1,26 @@ > +Maxim MAX77802 multi-function device > + > +The Maxim MAX77802 is a Power Management IC (PMIC) that contains 10 high > +efficiency Buck regulators, 32 Low-DropOut (LDO) regulators used to power > +up application processors and peripherals, a 2-channel 32kHz clock outputs, > +a Real-Time-Clock (RTC) and a I2C interface to program the individual > +regulators, clocks outputs and the RTC. > + > +Bindings for the built-in 32k clock generator block and > +regulators are defined in ../clk/maxim,max77802.txt and > +../regulator/max77802.txt respectively. > + > +Required properties: > +- compatible : Must be "maxim,max77802" > +- reg : Specifies the I2C slave address of PMIC block. > +- interrupts : I2C device IRQ line connected to the main SoC. > +- interrupt-parent : The parent interrupt controller. > + > +Example: > + > + max77802: pmic@09 { > + compatible = "maxim,max77802"; > + interrupt-parent = <&intc>; > + interrupts = <26 IRQ_TYPE_NONE>; > + reg = <0x09>; > + }; -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog