From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60206) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZTqQF-00080t-OD for qemu-devel@nongnu.org; Mon, 24 Aug 2015 08:00:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZTqQC-0001th-Gi for qemu-devel@nongnu.org; Mon, 24 Aug 2015 08:00:19 -0400 Received: from e28smtp08.in.ibm.com ([122.248.162.8]:37559) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZTqQB-0001sH-UE for qemu-devel@nongnu.org; Mon, 24 Aug 2015 08:00:16 -0400 Received: from /spool/local by e28smtp08.in.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 24 Aug 2015 17:30:10 +0530 Date: Mon, 24 Aug 2015 22:00:02 +1000 From: Gavin Shan Message-ID: <20150824120002.GA20078@gwshan> References: <1439190785-18908-1-git-send-email-gwshan@linux.vnet.ibm.com> <1439190785-18908-2-git-send-email-gwshan@linux.vnet.ibm.com> <20150824072315.GA11388@gwshan> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150824072315.GA11388@gwshan> Subject: Re: [Qemu-devel] [PATCH v4 1/3] linux-headers: Add eeh.h Reply-To: Gavin Shan List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gavin Shan Cc: Alexey Kardashevskiy , Peter Maydell , "qemu-ppc@nongnu.org" , QEMU Developers , David Gibson On Mon, Aug 24, 2015 at 05:23:15PM +1000, Gavin Shan wrote: >On Tue, Aug 11, 2015 at 10:11:03AM +0100, Peter Maydell wrote: >>On 10 August 2015 at 08:13, Gavin Shan wrote: >>> The header file was introduced by following Linux upstream commits: >>> >>> commit ed3e81f ("powerpc/eeh: Move PE state constants around") >>> commit ec33d36 ("powerpc/eeh: Introduce eeh_pe_inject_err()") >>> >>> Signed-off-by: Gavin Shan >>> --- >>> linux-headers/asm-powerpc/eeh.h | 56 +++++++++++++++++++++++++++++++++++++++++ >>> 1 file changed, 56 insertions(+) >>> create mode 100644 linux-headers/asm-powerpc/eeh.h >> >>Shouldn't this be added by updating scripts/update-linux-headers.sh >>and then doing a plain "synchronize headers against kernel version $X" ? >>Otherwise you won't get any future changes to this file. >> > >When I started to sync header files with 4.2.0-rc2 kernel, I found lots >of changes existing in the Linux kernel wasn't updated to QEMU source >tree. Some changes were introduced into the kernel in 2013, for example >commit 24bc69da ("PCI: Clean up MSI/MSI-X capability #defines"). Is there >any reason why the header file wasn't updated in time? > Anyway, I'll sync all headers with 4.2.rc8 and change the source code accordingly to use those macros valid in 4.2.rc8. >Also, "struct virtio_pci_cfg_cap" has been removed from 4.2.0-rc2 kernel, >but QEMU is still using it. If all header files are sync'ed with this >kernel, then the source code should be adjusted as well. I'm not sure >it's reasonable for someone who (like me) is unfamiliar with VFIO to do >so? :-) Please ignore this question. I was using wrong Linux git repository. After switching to Linux upstream (mainline), I didn't find this issue. Thanks, Gavin