From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Return-Path: Date: Tue, 25 Aug 2015 08:58:58 +0100 From: Lee Jones To: Vaibhav Hiremath Cc: linux-arm-kernel@lists.infradead.org, robh+dt@kernel.org, mturquette@baylibre.com, k.kozlowski@samsung.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org Subject: Re: [PATCH-v2 3/5] mfd: devicetree: bindings: Add clock subdevice node information Message-ID: <20150825075858.GH19409@x1> References: <1440442594-3102-1-git-send-email-vaibhav.hiremath@linaro.org> <1440442594-3102-5-git-send-email-vaibhav.hiremath@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 In-Reply-To: <1440442594-3102-5-git-send-email-vaibhav.hiremath@linaro.org> List-ID: On Tue, 25 Aug 2015, Vaibhav Hiremath wrote: > This patch updates the binding documentation for optional > clocks node and related information for buffered 32KHz clock. > > Signed-off-by: Vaibhav Hiremath > Reviewed-by: Krzysztof Kozlowski > Acked-by: Rob Herring > --- > Documentation/devicetree/bindings/mfd/88pm800.txt | 27 +++++++++++++++++++++++ > 1 file changed, 27 insertions(+) > > diff --git a/Documentation/devicetree/bindings/mfd/88pm800.txt b/Documentation/devicetree/bindings/mfd/88pm800.txt > index 2c82fcb..bc6cb02 100644 > --- a/Documentation/devicetree/bindings/mfd/88pm800.txt > +++ b/Documentation/devicetree/bindings/mfd/88pm800.txt > @@ -15,6 +15,26 @@ Optional properties : > Without this both BUCK1A and BUCK1B operates independently with 3A capacity. > (This property is only applicable to 88PM860) > > +Optional nodes: > +- clocks: 88pm800 family of devices provide multiple buffered 32.768 > + KHz outputs, so to register these as clocks with common clock framework > + instantiate a sub-node named "clocks". It uses the common clock binding > + documented in : > + [Documentation/devicetree/bindings/clock/clock-bindings.txt] I tend to prefer relative paths. Firstly because they're shorter and more succinct and secondly because if we do eventually move DT out of the kernel, it will be less hassle to rename each of them. > + - #clock-cells: should be 1. > + > + - The following is the list of clocks generated by the controller. Each clock > + is assigned an identifier and client nodes use this identifier to specify > + the clock which they consume. > + Clock ID Devices > + ---------------------------------------------------------- > + pm800_clk32k_1 0 88PM800 and 88PM860 > + pm800_clk32k_2 1 88PM800 and 88PM860 > + pm800_clk32k_3 2 88PM800 > + > + - compatible: Should be : "marvell,88pm800-clk" > + > 88pm80x family of devices consists of varied group of sub-devices: > > Device Supply Names Description > @@ -22,6 +42,7 @@ Device Supply Names Description > 88pm80x-onkey : : On key > 88pm80x-rtc : : RTC > 88pm80x-regulator : : Regulators > +88pm80x-clk : : 32KHz Clk provider Nit: Alphabetical? > Example: > > @@ -33,6 +54,12 @@ Example: > interrupt-controller; > #interrupt-cells = <1>; > > + pm800clk: clocks { > + compatible = "marvell,88pm800-clk"; > + #clock-cells = <1>; > + clock-output-names = "xx", "yy", "zz"; > + }; > + > regulators { > compatible = "marvell,88pm80x-regulator"; > -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog From mboxrd@z Thu Jan 1 00:00:00 1970 From: lee.jones@linaro.org (Lee Jones) Date: Tue, 25 Aug 2015 08:58:58 +0100 Subject: [PATCH-v2 3/5] mfd: devicetree: bindings: Add clock subdevice node information In-Reply-To: <1440442594-3102-5-git-send-email-vaibhav.hiremath@linaro.org> References: <1440442594-3102-1-git-send-email-vaibhav.hiremath@linaro.org> <1440442594-3102-5-git-send-email-vaibhav.hiremath@linaro.org> Message-ID: <20150825075858.GH19409@x1> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Tue, 25 Aug 2015, Vaibhav Hiremath wrote: > This patch updates the binding documentation for optional > clocks node and related information for buffered 32KHz clock. > > Signed-off-by: Vaibhav Hiremath > Reviewed-by: Krzysztof Kozlowski > Acked-by: Rob Herring > --- > Documentation/devicetree/bindings/mfd/88pm800.txt | 27 +++++++++++++++++++++++ > 1 file changed, 27 insertions(+) > > diff --git a/Documentation/devicetree/bindings/mfd/88pm800.txt b/Documentation/devicetree/bindings/mfd/88pm800.txt > index 2c82fcb..bc6cb02 100644 > --- a/Documentation/devicetree/bindings/mfd/88pm800.txt > +++ b/Documentation/devicetree/bindings/mfd/88pm800.txt > @@ -15,6 +15,26 @@ Optional properties : > Without this both BUCK1A and BUCK1B operates independently with 3A capacity. > (This property is only applicable to 88PM860) > > +Optional nodes: > +- clocks: 88pm800 family of devices provide multiple buffered 32.768 > + KHz outputs, so to register these as clocks with common clock framework > + instantiate a sub-node named "clocks". It uses the common clock binding > + documented in : > + [Documentation/devicetree/bindings/clock/clock-bindings.txt] I tend to prefer relative paths. Firstly because they're shorter and more succinct and secondly because if we do eventually move DT out of the kernel, it will be less hassle to rename each of them. > + - #clock-cells: should be 1. > + > + - The following is the list of clocks generated by the controller. Each clock > + is assigned an identifier and client nodes use this identifier to specify > + the clock which they consume. > + Clock ID Devices > + ---------------------------------------------------------- > + pm800_clk32k_1 0 88PM800 and 88PM860 > + pm800_clk32k_2 1 88PM800 and 88PM860 > + pm800_clk32k_3 2 88PM800 > + > + - compatible: Should be : "marvell,88pm800-clk" > + > 88pm80x family of devices consists of varied group of sub-devices: > > Device Supply Names Description > @@ -22,6 +42,7 @@ Device Supply Names Description > 88pm80x-onkey : : On key > 88pm80x-rtc : : RTC > 88pm80x-regulator : : Regulators > +88pm80x-clk : : 32KHz Clk provider Nit: Alphabetical? > Example: > > @@ -33,6 +54,12 @@ Example: > interrupt-controller; > #interrupt-cells = <1>; > > + pm800clk: clocks { > + compatible = "marvell,88pm800-clk"; > + #clock-cells = <1>; > + clock-output-names = "xx", "yy", "zz"; > + }; > + > regulators { > compatible = "marvell,88pm80x-regulator"; > -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org ? Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Subject: Re: [PATCH-v2 3/5] mfd: devicetree: bindings: Add clock subdevice node information Date: Tue, 25 Aug 2015 08:58:58 +0100 Message-ID: <20150825075858.GH19409@x1> References: <1440442594-3102-1-git-send-email-vaibhav.hiremath@linaro.org> <1440442594-3102-5-git-send-email-vaibhav.hiremath@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <1440442594-3102-5-git-send-email-vaibhav.hiremath@linaro.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Vaibhav Hiremath Cc: devicetree@vger.kernel.org, k.kozlowski@samsung.com, mturquette@baylibre.com, linux-kernel@vger.kernel.org, robh+dt@kernel.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org List-Id: devicetree@vger.kernel.org T24gVHVlLCAyNSBBdWcgMjAxNSwgVmFpYmhhdiBIaXJlbWF0aCB3cm90ZToKCj4gVGhpcyBwYXRj aCB1cGRhdGVzIHRoZSBiaW5kaW5nIGRvY3VtZW50YXRpb24gZm9yIG9wdGlvbmFsCj4gY2xvY2tz IG5vZGUgYW5kIHJlbGF0ZWQgaW5mb3JtYXRpb24gZm9yIGJ1ZmZlcmVkIDMyS0h6IGNsb2NrLgo+ IAo+IFNpZ25lZC1vZmYtYnk6IFZhaWJoYXYgSGlyZW1hdGggPHZhaWJoYXYuaGlyZW1hdGhAbGlu YXJvLm9yZz4KPiBSZXZpZXdlZC1ieTogS3J6eXN6dG9mIEtvemxvd3NraSA8ay5rb3psb3dza2lA c2Ftc3VuZy5jb20+Cj4gQWNrZWQtYnk6IFJvYiBIZXJyaW5nIDxyb2JoQGtlcm5lbC5vcmc+Cj4g LS0tCj4gIERvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9tZmQvODhwbTgwMC50eHQg fCAyNyArKysrKysrKysrKysrKysrKysrKysrKwo+ICAxIGZpbGUgY2hhbmdlZCwgMjcgaW5zZXJ0 aW9ucygrKQo+IAo+IGRpZmYgLS1naXQgYS9Eb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGlu Z3MvbWZkLzg4cG04MDAudHh0IGIvRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL21m ZC84OHBtODAwLnR4dAo+IGluZGV4IDJjODJmY2IuLmJjNmNiMDIgMTAwNjQ0Cj4gLS0tIGEvRG9j dW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL21mZC84OHBtODAwLnR4dAo+ICsrKyBiL0Rv Y3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9tZmQvODhwbTgwMC50eHQKPiBAQCAtMTUs NiArMTUsMjYgQEAgT3B0aW9uYWwgcHJvcGVydGllcyA6Cj4gICAgV2l0aG91dCB0aGlzIGJvdGgg QlVDSzFBIGFuZCBCVUNLMUIgb3BlcmF0ZXMgaW5kZXBlbmRlbnRseSB3aXRoIDNBIGNhcGFjaXR5 Lgo+ICAgIChUaGlzIHByb3BlcnR5IGlzIG9ubHkgYXBwbGljYWJsZSB0byA4OFBNODYwKQo+ICAK PiArT3B0aW9uYWwgbm9kZXM6Cj4gKy0gY2xvY2tzOiA4OHBtODAwIGZhbWlseSBvZiBkZXZpY2Vz IHByb3ZpZGUgbXVsdGlwbGUgYnVmZmVyZWQgMzIuNzY4Cj4gKyAgS0h6IG91dHB1dHMsIHNvIHRv IHJlZ2lzdGVyIHRoZXNlIGFzIGNsb2NrcyB3aXRoIGNvbW1vbiBjbG9jayBmcmFtZXdvcmsKPiAr ICBpbnN0YW50aWF0ZSBhIHN1Yi1ub2RlIG5hbWVkICJjbG9ja3MiLiBJdCB1c2VzIHRoZSBjb21t b24gY2xvY2sgYmluZGluZwo+ICsgIGRvY3VtZW50ZWQgaW4gOgo+ICsgIFtEb2N1bWVudGF0aW9u L2RldmljZXRyZWUvYmluZGluZ3MvY2xvY2svY2xvY2stYmluZGluZ3MudHh0XQoKSSB0ZW5kIHRv IHByZWZlciByZWxhdGl2ZSBwYXRocy4gIEZpcnN0bHkgYmVjYXVzZSB0aGV5J3JlIHNob3J0ZXIg YW5kCm1vcmUgc3VjY2luY3QgYW5kIHNlY29uZGx5IGJlY2F1c2UgaWYgd2UgZG8gZXZlbnR1YWxs eSBtb3ZlIERUIG91dCBvZgp0aGUga2VybmVsLCBpdCB3aWxsIGJlIGxlc3MgaGFzc2xlIHRvIHJl bmFtZSBlYWNoIG9mIHRoZW0uCgo+ICsgIC0gI2Nsb2NrLWNlbGxzOiBzaG91bGQgYmUgMS4KPiAr Cj4gKyAgLSBUaGUgZm9sbG93aW5nIGlzIHRoZSBsaXN0IG9mIGNsb2NrcyBnZW5lcmF0ZWQgYnkg dGhlIGNvbnRyb2xsZXIuIEVhY2ggY2xvY2sKPiArICAgIGlzIGFzc2lnbmVkIGFuIGlkZW50aWZp ZXIgYW5kIGNsaWVudCBub2RlcyB1c2UgdGhpcyBpZGVudGlmaWVyIHRvIHNwZWNpZnkKPiArICAg IHRoZSBjbG9jayB3aGljaCB0aGV5IGNvbnN1bWUuCj4gKyAgICBDbG9jawkJSUQgICAgICAgICAg IAlEZXZpY2VzCj4gKyAgICAtLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tCj4gKyAgICBwbTgwMF9jbGszMmtfMQkwCQk4OFBNODAwIGFuZCA4 OFBNODYwCj4gKyAgICBwbTgwMF9jbGszMmtfMgkxCQk4OFBNODAwIGFuZCA4OFBNODYwCj4gKyAg ICBwbTgwMF9jbGszMmtfMwkyCQk4OFBNODAwCj4gKwo+ICsgIC0gY29tcGF0aWJsZTogU2hvdWxk IGJlIDogIm1hcnZlbGwsODhwbTgwMC1jbGsiCj4gKwo+ICA4OHBtODB4IGZhbWlseSBvZiBkZXZp Y2VzIGNvbnNpc3RzIG9mIHZhcmllZCBncm91cCBvZiBzdWItZGV2aWNlczoKPiAgCj4gIERldmlj ZQkJIAlTdXBwbHkgTmFtZXMJIERlc2NyaXB0aW9uCj4gQEAgLTIyLDYgKzQyLDcgQEAgRGV2aWNl CQkgCVN1cHBseSBOYW1lcwkgRGVzY3JpcHRpb24KPiAgODhwbTgweC1vbmtleQkJOgkJOiBPbiBr ZXkKPiAgODhwbTgweC1ydGMJCToJCTogUlRDCj4gIDg4cG04MHgtcmVndWxhdG9yCToJCTogUmVn dWxhdG9ycwo+ICs4OHBtODB4LWNsawkJOgkJOiAzMktIeiBDbGsgcHJvdmlkZXIKCk5pdDogQWxw aGFiZXRpY2FsPwoKPiAgRXhhbXBsZToKPiAgCj4gQEAgLTMzLDYgKzU0LDEyIEBAIEV4YW1wbGU6 Cj4gIAkJaW50ZXJydXB0LWNvbnRyb2xsZXI7Cj4gIAkJI2ludGVycnVwdC1jZWxscyA9IDwxPjsK PiAgCj4gKwkJcG04MDBjbGs6IGNsb2NrcyB7Cj4gKwkJCWNvbXBhdGlibGUgPSAibWFydmVsbCw4 OHBtODAwLWNsayI7Cj4gKwkJCSNjbG9jay1jZWxscyA9IDwxPjsKPiArCQkJY2xvY2stb3V0cHV0 LW5hbWVzID0gInh4IiwgInl5IiwgInp6IjsKPiArCQl9Owo+ICsKPiAgCQlyZWd1bGF0b3JzIHsK PiAgCQkJY29tcGF0aWJsZSA9ICJtYXJ2ZWxsLDg4cG04MHgtcmVndWxhdG9yIjsKPiAgCgotLSAK TGVlIEpvbmVzCkxpbmFybyBTVE1pY3JvZWxlY3Ryb25pY3MgTGFuZGluZyBUZWFtIExlYWQKTGlu YXJvLm9yZyDilIIgT3BlbiBzb3VyY2Ugc29mdHdhcmUgZm9yIEFSTSBTb0NzCkZvbGxvdyBMaW5h cm86IEZhY2Vib29rIHwgVHdpdHRlciB8IEJsb2cKCl9fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4 LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK